Re: [PATCH for-4.7 0/6] Workaround gcc -Wmaybe-uninitialised false positive reports

[Wei Liu <wei.liu2@citrix.com>]

On Fri, May 06, 2016 at 08:37:31AM -0500, Doug Goldstein wrote:
> On 4/29/16 10:11 AM, Wei Liu wrote:
> > On my Debian Jessie build box gcc complains about various maybe uninitialised
> > variables when -g is in use. In fact gcc -Wmaybe-uninitialized is not very
> > reliable according to gcc manpage, various search results and answer from
> > someone on freenode #gcc channel.
> > 
> > I go through those failures and try to provide some workaround for them.
> > Please have a look if these fixes make sense or my analysis is correct.
> > 
> > Wei.
> > 
> > Wei Liu (6):
> >   rombios/tcgbios: initialise size in tcpa_extend_acpi_log
> >   rombios/tcgbios: initialise entry in HashLogEvent32
> >   rombios/tcgbios: initialise logdataptr in HashLogEvent32
> >   blktap2: initialise buf in vhd_util_check_footer
> >   blktap2: initialise buf to NULL in img2qcow.c:main
> >   blktap2: initialise buf in qcow2raw.c:main
> > 
> >  tools/blktap2/drivers/img2qcow.c               | 2 +-
> >  tools/blktap2/drivers/qcow2raw.c               | 2 +-
> >  tools/blktap2/vhd/lib/vhd-util-check.c         | 2 +-
> >  tools/firmware/rombios/32bit/tcgbios/tcgbios.c | 6 +++---
> >  4 files changed, 6 insertions(+), 6 deletions(-)
> > 
> 
> For the whole series:
> 
> Reviewed-by: Doug Goldstein <cardoe@cardoe.com>
> 

Thanks.

I chatted with Ian on IRC he said he didn't quite like this approach but
didn't have better suggestion so I should go ahead.

I've queued this series up for committing.

Wei.

> -- 
> Doug Goldstein
> 




_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel