From: Wei Liu <wei.liu2@citrix.com>
To: George Dunlap <george.dunlap@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Dario Faggioli <dario.faggioli@citrix.com>,
Tianyang Chen <tiche@seas.upenn.edu>,
Wei Liu <wei.liu2@citrix.com>, Meng Xu <mengxu@cis.upenn.edu>
Subject: Re: [PATCH for 4.7 4/4] xen: adopt .deinit_pdata and improve timer handling
Date: Mon, 9 May 2016 15:58:52 +0100 [thread overview]
Message-ID: <20160509145852.GA17769@citrix.com> (raw)
In-Reply-To: <CAFLBxZZC47VBjvDnv-TUrq2_owqfu+4uKeC+Wx-=8C6_bxxUpA@mail.gmail.com>
On Mon, May 09, 2016 at 03:46:23PM +0100, George Dunlap wrote:
> On Sat, May 7, 2016 at 10:19 PM, Meng Xu <mengxu@cis.upenn.edu> wrote:
> > On Tue, May 3, 2016 at 5:46 PM, Dario Faggioli
> > <dario.faggioli@citrix.com> wrote:
> >>
> >> The scheduling hooks API is now used properly, and no
> >> initialization or de-initialization happen in
> >> alloc/free_pdata any longer.
> >>
> >> In fact, just like it is for Credit2, there is no real
> >> need for implementing alloc_pdata and free_pdata.
> >>
> >> This also made it possible to improve the replenishment
> >> timer handling logic, such that now the timer is always
> >> kept on one of the pCPU of the scheduler it's servicing.
> >> Before this commit, in fact, even if the pCPU where the
> >> timer happened to be initialized at creation time was
> >> moved to another cpupool, the timer stayed there,
> >> potentially inferfearing with the new scheduler of the
> >> pCPU itself.
> >>
> >> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> >> --
> >
> > Reviewed-and-Tested-by: Meng Xu <mengxu@cis.upenn.edu>
>
> And on that basis:
>
> Acked-by: George Dunlap <george.dunlap@citrix.com>
>
> But it looks like it still needs a release ack?
>
Release-acked-by: Wei Liu <wei.liu2@citrix.com>
> -George
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-05-09 14:59 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 21:46 [PATCH for 4.7 0/4] Assorted scheduling fixes Dario Faggioli
2016-05-03 21:46 ` [PATCH for 4.7 1/4] xen: sched: avoid spuriously re-enabling IRQs in csched2_switch_sched() Dario Faggioli
2016-05-04 8:48 ` Jan Beulich
2016-05-04 9:08 ` Dario Faggioli
2016-05-04 15:11 ` George Dunlap
2016-05-04 15:58 ` Dario Faggioli
2016-05-04 17:05 ` George Dunlap
2016-05-04 17:21 ` Dario Faggioli
2016-05-04 17:34 ` George Dunlap
2016-05-06 13:21 ` Dario Faggioli
2016-05-06 13:48 ` Wei Liu
2016-05-09 14:42 ` George Dunlap
2016-05-03 21:46 ` [PATCH for 4.7 2/4] xen: sched: fix killing an uninitialized timer in free_pdata Dario Faggioli
2016-05-04 15:25 ` George Dunlap
2016-05-03 21:46 ` [PATCH for 4.7 3/4] xen: credit2: fix 2 (minor) issues in load tracking logic Dario Faggioli
2016-05-04 15:38 ` George Dunlap
2016-05-03 21:46 ` [PATCH for 4.7 4/4] xen: adopt .deinit_pdata and improve timer handling Dario Faggioli
2016-05-04 15:51 ` George Dunlap
2016-05-04 15:53 ` Meng Xu
2016-05-06 23:05 ` Dario Faggioli
2016-05-07 21:19 ` Meng Xu
2016-05-08 3:12 ` Meng Xu
2016-05-09 8:07 ` Juergen Gross
2016-05-09 13:22 ` Dario Faggioli
2016-05-09 14:08 ` Meng Xu
2016-05-09 14:52 ` Dario Faggioli
2016-05-09 14:58 ` Meng Xu
2016-05-09 14:46 ` George Dunlap
2016-05-09 14:58 ` Wei Liu [this message]
2016-05-09 15:35 ` George Dunlap
2016-05-04 1:26 ` [PATCH for 4.7 0/4] Assorted scheduling fixes Konrad Rzeszutek Wilk
2016-05-04 9:06 ` Dario Faggioli
2016-05-05 12:00 ` Julien Grall
2016-05-05 12:38 ` Dario Faggioli
2016-05-04 15:53 ` George Dunlap
2016-05-04 16:04 ` Wei Liu
2016-05-07 21:23 ` Meng Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160509145852.GA17769@citrix.com \
--to=wei.liu2@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=mengxu@cis.upenn.edu \
--cc=tiche@seas.upenn.edu \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).