From: Wei Liu <wei.liu2@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>,
George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [RFC] libxl hotplug / unplug emulated devices
Date: Fri, 20 May 2016 19:05:57 +0100 [thread overview]
Message-ID: <20160520180557.GH31272@citrix.com> (raw)
In-Reply-To: <20160520180420.GG31272@citrix.com>
On Fri, May 20, 2016 at 07:04:20PM +0100, Wei Liu wrote:
> On Fri, May 20, 2016 at 06:58:40PM +0100, Ian Jackson wrote:
> > Wei Liu writes ("Re: [RFC] libxl hotplug / unplug emulated devices"):
> > > On Fri, May 20, 2016 at 05:38:44PM +0100, Ian Jackson wrote:
> > > > Maybe the fix should be that xl network-attach should default hotplug
> > > > nics to pv only.
> > >
> > > Here is a patch to do this. :-)
> >
> > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> >
> > Although I have a style nit:
> >
> > > if (libxl__device_model_version_running(gc, domid) ==
> > > - LIBXL_DEVICE_MODEL_VERSION_NONE)
> > > + LIBXL_DEVICE_MODEL_VERSION_NONE || hotplug)
> > > nic->nictype = LIBXL_NIC_TYPE_VIF;
> >
> > This is rather odd formatting. It makes it look like
> > if (version = (NONE || hotplug)) { ...
> >
>
> Perhaps you mean
>
> if ((version == NONE) || hotplug)
>
> ?
Never mind. I misread.
I will fix that.
>
> > You might prefer to put another line break, before the || perhaps.
> >
> > Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-05-20 18:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 16:34 [RFC] libxl hotplug / unplug emulated devices Wei Liu
2016-05-20 16:38 ` Ian Jackson
2016-05-20 16:42 ` Wei Liu
2016-05-20 16:45 ` Andrew Cooper
2016-05-20 16:49 ` Wei Liu
2016-05-20 17:45 ` Wei Liu
2016-05-20 17:58 ` Ian Jackson
2016-05-20 18:04 ` Wei Liu
2016-05-20 18:05 ` Ian Jackson
2016-05-20 18:05 ` Wei Liu [this message]
2016-05-23 9:32 ` George Dunlap
2016-05-23 10:28 ` Wei Liu
2016-05-23 10:45 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160520180557.GH31272@citrix.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=anthony.perard@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).