xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Doug Goldstein <cardoe@cardoe.com>, xen-devel@lists.xen.org
Subject: Re: [PATCH v4 0/6] Kconfig debug options
Date: Mon, 23 May 2016 09:23:44 -0400	[thread overview]
Message-ID: <20160523132344.GI25856@char.us.oracle.com> (raw)
In-Reply-To: <57419903.4040202@citrix.com>

On Sun, May 22, 2016 at 12:33:23PM +0100, Andrew Cooper wrote:
> On 22/05/16 06:01, Doug Goldstein wrote:
> > This converts the debug options from xen/Rules.mk to Kconfig. Hopefully
> > I haven't missed anything in the back and forth.
> >
> > change since v3:
> > - wrap all options in 'if DEBUG || EXPERT' (except DEBUG)
> > - wording update to DEBUG option and some commit messages
> > - all old command line options now complain
> > change since v2:
> > - dropped patch 5 as it was unwanted
> > - remove 'default n'
> > - redid patch 1
> >
> >
> > *** BLURB HERE ***
> >
> > Doug Goldstein (6):
> >   build: convert debug to Kconfig
> >   build: convert crash_debug to Kconfig
> >   build: convert verbose to Kconfig
> >   build: convert frame_pointer to Kconfig
> >   build: convert perfc{,_arrays} to Kconfig
> >   build: convert lock_profile to Kconfig
> 
> All Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

With the little nitpicks I pointed out - and the #1 redo as Jan
pointed out:

Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-05-23 13:23 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-22  5:01 [PATCH v4 0/6] Kconfig debug options Doug Goldstein
2016-05-22  5:01 ` [PATCH v4 1/6] build: convert debug to Kconfig Doug Goldstein
2016-05-22 19:04   ` Doug Goldstein
2016-05-23  8:39     ` Jan Beulich
2016-05-24  2:36       ` Doug Goldstein
2016-05-23 12:58   ` Jan Beulich
2016-05-23 13:19     ` Andrew Cooper
2016-05-24  2:32       ` Doug Goldstein
2016-05-24  1:03     ` Doug Goldstein
2016-05-24  7:09       ` Jan Beulich
2016-05-22  5:01 ` [PATCH v4 2/6] build: convert crash_debug " Doug Goldstein
2016-05-23 13:22   ` Konrad Rzeszutek Wilk
2016-05-24  2:41     ` Doug Goldstein
2016-05-22  5:01 ` [PATCH v4 3/6] build: convert verbose " Doug Goldstein
2016-05-23 13:19   ` Konrad Rzeszutek Wilk
2016-05-24  2:43     ` Doug Goldstein
2016-05-22  5:01 ` [PATCH v4 4/6] build: convert frame_pointer " Doug Goldstein
2016-05-22  5:01 ` [PATCH v4 5/6] build: convert perfc{, _arrays} " Doug Goldstein
2016-05-23 13:21   ` Konrad Rzeszutek Wilk
2016-05-22  5:01 ` [PATCH v4 6/6] build: convert lock_profile " Doug Goldstein
2016-05-23 15:53   ` Julien Grall
2016-05-24  2:50     ` Doug Goldstein
2016-05-22 11:33 ` [PATCH v4 0/6] Kconfig debug options Andrew Cooper
2016-05-23 13:23   ` Konrad Rzeszutek Wilk [this message]
2016-05-23 13:05 ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160523132344.GI25856@char.us.oracle.com \
    --to=konrad.wilk@oracle.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=cardoe@cardoe.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).