xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] libxl: drop stray const from function return type
@ 2016-05-24 15:28 Jan Beulich
  2016-05-24 15:42 ` Ian Jackson
  0 siblings, 1 reply; 3+ messages in thread
From: Jan Beulich @ 2016-05-24 15:28 UTC (permalink / raw)
  To: xen-devel; +Cc: Ian Jackson, Wei Liu

[-- Attachment #1: Type: text/plain, Size: 589 bytes --]

Some compiler versions warn about this, causing the build to fail due
to -Werror.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/tools/libxl/libxl.c
+++ b/tools/libxl/libxl.c
@@ -5354,8 +5354,8 @@ libxl_numainfo *libxl_get_numainfo(libxl
     return ret;
 }
 
-static const int libxl__xc_version_wrap(libxl__gc *gc, libxl_version_info *info,
-                                        xen_build_id_t *build)
+static int libxl__xc_version_wrap(libxl__gc *gc, libxl_version_info *info,
+                                  xen_build_id_t *build)
 {
     int r;
 




[-- Attachment #2: libxl-no-const-return-type.patch --]
[-- Type: text/plain, Size: 636 bytes --]

libxl: drop stray const from function return type

Some compiler versions warn about this, causing the build to fail due
to -Werror.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/tools/libxl/libxl.c
+++ b/tools/libxl/libxl.c
@@ -5354,8 +5354,8 @@ libxl_numainfo *libxl_get_numainfo(libxl
     return ret;
 }
 
-static const int libxl__xc_version_wrap(libxl__gc *gc, libxl_version_info *info,
-                                        xen_build_id_t *build)
+static int libxl__xc_version_wrap(libxl__gc *gc, libxl_version_info *info,
+                                  xen_build_id_t *build)
 {
     int r;
 

[-- Attachment #3: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] libxl: drop stray const from function return type
  2016-05-24 15:28 [PATCH] libxl: drop stray const from function return type Jan Beulich
@ 2016-05-24 15:42 ` Ian Jackson
  2016-05-24 15:44   ` Wei Liu
  0 siblings, 1 reply; 3+ messages in thread
From: Ian Jackson @ 2016-05-24 15:42 UTC (permalink / raw)
  To: Jan Beulich; +Cc: xen-devel, Wei Liu

Jan Beulich writes ("[PATCH] libxl: drop stray const from function return type"):
> Some compiler versions warn about this, causing the build to fail due
> to -Werror.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] libxl: drop stray const from function return type
  2016-05-24 15:42 ` Ian Jackson
@ 2016-05-24 15:44   ` Wei Liu
  0 siblings, 0 replies; 3+ messages in thread
From: Wei Liu @ 2016-05-24 15:44 UTC (permalink / raw)
  To: Ian Jackson; +Cc: xen-devel, Wei Liu, Jan Beulich

On Tue, May 24, 2016 at 04:42:12PM +0100, Ian Jackson wrote:
> Jan Beulich writes ("[PATCH] libxl: drop stray const from function return type"):
> > Some compiler versions warn about this, causing the build to fail due
> > to -Werror.
> > 
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

Queued.

Thank you both.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-05-24 15:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-24 15:28 [PATCH] libxl: drop stray const from function return type Jan Beulich
2016-05-24 15:42 ` Ian Jackson
2016-05-24 15:44   ` Wei Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).