From: Wei Liu <wei.liu2@citrix.com>
To: George Dunlap <george.dunlap@citrix.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>
Subject: Re: [PATCH QEMU for-4.7] main loop: Big hammer to fix logfile disk DoS in Xen setups
Date: Thu, 26 May 2016 16:39:01 +0100 [thread overview]
Message-ID: <20160526153901.GY22076@citrix.com> (raw)
In-Reply-To: <CAFLBxZaMM9TcwjZrxv4uOGqfjS4+NGwnB_1jVkw9MykKBZUXyw@mail.gmail.com>
On Thu, May 26, 2016 at 04:36:57PM +0100, George Dunlap wrote:
> On Thu, May 26, 2016 at 4:21 PM, Wei Liu <wei.liu2@citrix.com> wrote:
> > From: Ian Jackson <ian.jackson@eu.citrix.com>
> >
> > Each time round the main loop, we now fstat stderr. If it is too big,
> > we dup2 /dev/null onto it. This is not a very pretty patch but it is
> > very simple, easy to see that it's correct, and has a low risk of
> > collateral damage.
> >
> > The limit is 1Mby by default but can be adjusted by setting a new
> > environment variable.
>
> There is no limit by default; a companion patch for libxl sets this to
> 1MiB. This is so that this patch may be applied on a system qemu
> which is shared between multiple use cases (including non-Xen cases).
>
I added a paragraph in that patch and have my S-o-B.
Did you miss that? Or do you mean I should rewrite the commit message
altogether?
Wei.
> -George
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-05-26 15:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 15:19 [PATCH for-4.7] XSA-180 patches for 4.7 Wei Liu
2016-05-26 15:21 ` [PATCH for-4.7] libxl: set XEN_QEMU_CONSOLE_LIMIT for QEMU Wei Liu
2016-05-26 15:21 ` [PATCH QEMU for-4.7] main loop: Big hammer to fix logfile disk DoS in Xen setups Wei Liu
2016-05-26 15:36 ` George Dunlap
2016-05-26 15:39 ` Wei Liu [this message]
2016-05-26 15:42 ` Ian Jackson
2016-05-26 16:10 ` Anthony PERARD
2016-05-26 16:50 ` Anthony PERARD
2016-05-26 15:41 ` [PATCH for-4.7] libxl: set XEN_QEMU_CONSOLE_LIMIT for QEMU Ian Jackson
2016-05-26 15:47 ` Wei Liu
2016-05-26 15:54 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160526153901.GY22076@citrix.com \
--to=wei.liu2@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).