xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: paul.durrant@citrix.com, Wei Liu <wei.liu2@citrix.com>,
	george.dunlap@citrix.com, suravee.suthikulpanit@amd.com,
	xen-devel@lists.xen.org
Subject: Re: [PATCH v4 1/2] AMD IOMMU: Removing currently non-functioning guest iommu feature
Date: Thu, 2 Jun 2016 11:26:01 +0100	[thread overview]
Message-ID: <20160602102601.GS5160@citrix.com> (raw)
In-Reply-To: <57501EBE02000078000F0D26@prv-mh.provo.novell.com>

On Thu, Jun 02, 2016 at 03:55:41AM -0600, Jan Beulich wrote:
> >>> On 01.06.16 at 21:52, <suravee.suthikulpanit@amd.com> wrote:
> > From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
> > 
> > The guest IOMMU feature is currently not functioning. However,
> > the current guest_iommu_init() is causing issue when it tries to
> > register mmio handler because the it is currently called by the
> > following code path:
> > 
> >   arch/x86/domain.c: arch_domain_create()
> >     ]- drivers/passthrough/iommu.c: iommu_domain_init()
> >       |- drivers/passthrough/amd/pci_amd_iommu.c: amd_iommu_domain_init();
> >         |- drivers/passthrough/amd/iommu_guest.c: guest_iommu_init()
> > 
> > At this point, the hvm_domain_initialised() has not been called.
> > So register_mmio_handler() in guest_iommu_init() silently fails.
> > 
> > This patch removes the guest IOMMU feature for now until we can properly
> > support it.
> > 
> > Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> 
> Thanks, quite reasonable. And imo actually a 4.7 candidate. Wei?
> 

Release-acked-by: Wei Liu <wei.liu2@citrix.com>

Please apply this series within this week.

> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-06-02 10:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-01 19:52 [PATCH v4 0/2] Fix xen crash when starting HVM guest due to missing io handler suravee.suthikulpanit
2016-06-01 19:52 ` [PATCH v4 1/2] AMD IOMMU: Removing currently non-functioning guest iommu feature suravee.suthikulpanit
2016-06-02  8:01   ` Paul Durrant
2016-06-02  9:55   ` Jan Beulich
2016-06-02 10:26     ` Wei Liu [this message]
2016-06-02 10:43       ` Jan Beulich
2016-06-02 10:49         ` Wei Liu
2016-06-01 19:53 ` [PATCH v4 2/2] x86/hvm: Add check when register io handler suravee.suthikulpanit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160602102601.GS5160@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=george.dunlap@citrix.com \
    --cc=paul.durrant@citrix.com \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).