xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
	WeiLiu <wei.liu2@citrix.com>,
	"Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Ian Jackson" <ian.jackson@eu.citrix.com>,
	"Tim Deegan" <tim@xen.org>, "Jan Beulich" <JBeulich@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>,
	"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: when to bump library versions (was: <blank>)
Date: Mon, 6 Jun 2016 13:33:32 +0100	[thread overview]
Message-ID: <20160606123332.GB14588@citrix.com> (raw)
In-Reply-To: <CAFLBxZZnU0vm12rKpDWZu9ohcccSCRogZf-qGh1isA+eNA26yA@mail.gmail.com>

On Mon, May 23, 2016 at 12:06:40PM +0100, George Dunlap wrote:
> On Thu, May 19, 2016 at 4:01 PM, Jan Beulich <JBeulich@suse.com> wrote:
> >>>> On 19.05.16 at 16:53, <roger.pau@citrix.com> wrote:
> >> On Thu, May 19, 2016 at 08:44:59AM -0600, Jan Beulich wrote:
> >>> >>> On 19.05.16 at 16:34, <roger.pau@citrix.com> wrote:
> >>> > We could even have the
> >>> > library name versions be set based on XEN_VERSION and XEN_SUBVERSION, so
> >>> > that we don't need to go around the different library makefiles bumping the
> >>> > versions manually.
> >>>
> >>> But so far these two are intentionally private to the xen/ subtree.
> >>
> >> Maybe I'm missing something, but couldn't they be global to the whole tree?
> >> (Config.mk seems like a suitable place).
> >
> > I think originally the idea was that the tool stack isn't really tied to
> > a specific hypervisor version. What it is tied to is an interface
> > version (of namely domctl and sysctl).
> 
> Sure -- but is this actually useful, and even if it is, is it worth the cost?
> 
> Advantages of bumping version number only when the interface actually changes:
> 
> * Someone who links against an unstable library can in theory re-use
> the same binary after upgrading without re-compiling, *if* the
> interface didn't change
> 
> Advantages of bumping the version number as soon as the tree opens:
> 
> * We don't have to think about whether we need to bump the interface
> version or not; it happens as part of the branching checklist
> * You can install the most recent release and xen on the same box
> without the libraries (which may actually be incompatible, since the
> interface may have changed without the version number being bumped)
> being overwritten.
> 
> Looking just at those, I think it's pretty clear which is more useful.
> Are there other angles we should consider?
> 

I think it would make sense to just bump the version numbers of the
libraries that we don't have clear commitment on API and ABI stability.
That is everything other than the ones in libs. The one in libs can be
bump when necessary.

Wei.

>  -George

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

      reply	other threads:[~2016-06-06 12:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-19 14:34 (no subject) Roger Pau Monné
2016-05-19 14:44 ` when to bump library versions (was: <blank>) Jan Beulich
2016-05-19 14:53   ` Roger Pau Monné
2016-05-19 15:01     ` Jan Beulich
2016-05-23 11:06       ` George Dunlap
2016-06-06 12:33         ` Wei Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160606123332.GB14588@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=roger.pau@citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).