From: Olaf Hering <olaf@aepfle.de>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Dongli Zhang <dongli.zhang@oracle.com>,
xen-devel@lists.xen.org, ian.jackson@eu.citrix.com,
ross.lagerwall@citrix.com
Subject: Re: [PATCH v2 1/1] tools/livepatch: cleanup unnecessary "j = ARRAY_SIZE(action_options); "
Date: Wed, 15 Jun 2016 11:04:40 +0200 [thread overview]
Message-ID: <20160615090440.GA11583@gmail.com> (raw)
In-Reply-To: <20160615085217.GV28116@citrix.com>
On Wed, Jun 15, Wei Liu wrote:
> To fix the breakage, please check out staging branch and write a patch
> to fix it. And maybe the commit message should say something like
> "initialise j to 0 to make some versions of gcc happy".
Not "some", but rather "at least gcc4.5/4.3" or similar.
There are already enough "some"s out there, where in the end noone knows
what the given workaround is all about.
Olaf
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-15 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 0:41 [PATCH v2 1/1] tools/livepatch: cleanup unnecessary "j = ARRAY_SIZE(action_options); " Dongli Zhang
2016-06-15 8:52 ` Wei Liu
2016-06-15 9:04 ` Olaf Hering [this message]
2016-06-15 9:10 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160615090440.GA11583@gmail.com \
--to=olaf@aepfle.de \
--cc=dongli.zhang@oracle.com \
--cc=ian.jackson@eu.citrix.com \
--cc=ross.lagerwall@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).