From: Wei Liu <wei.liu2@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Doug Goldstein <cardoe@cardoe.com>, Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v2 2/2] xen: make available hvm_fep to non-debug build as well
Date: Fri, 17 Jun 2016 14:35:58 +0100 [thread overview]
Message-ID: <20160617133558.GC28116@citrix.com> (raw)
In-Reply-To: <5763FC4F02000078000F6216@prv-mh.provo.novell.com>
On Fri, Jun 17, 2016 at 05:34:07AM -0600, Jan Beulich wrote:
> >>> On 17.06.16 at 13:05, <wei.liu2@citrix.com> wrote:
> > --- a/xen/arch/x86/Kconfig
> > +++ b/xen/arch/x86/Kconfig
> > @@ -59,6 +59,20 @@ config BIGMEM
> >
> > If unsure, say N.
> >
> > +config HVM_FEP
> > + bool "HVM Forced Emulation Prefix support"
>
> And no "if EXPERT"?
>
Done.
> > @@ -95,9 +96,9 @@ unsigned long __section(".bss.page_aligned")
> > static bool_t __initdata opt_hap_enabled = 1;
> > boolean_param("hap", opt_hap_enabled);
> >
> > -#ifndef opt_hvm_fep
> > +#if CONFIG_HVM_FEP
>
> #ifdef please. And I think this would better be left alone anyway
> (and then the comment only applies to the other instance).
>
Change this instance back to what is was and fix the other.
Wei.
> Jan
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-17 13:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 11:05 [PATCH v2 0/2] Make hvm_fep available to non-debug build Wei Liu
2016-06-17 11:05 ` [PATCH v2 1/2] xen/kernel: document 'C' in print_tainted Wei Liu
2016-06-17 11:05 ` [PATCH v2 2/2] xen: make available hvm_fep to non-debug build as well Wei Liu
2016-06-17 11:34 ` Jan Beulich
2016-06-17 13:35 ` Wei Liu [this message]
2016-06-17 13:51 ` Andrew Cooper
2016-06-17 14:28 ` Jan Beulich
2016-06-17 14:32 ` Wei Liu
2016-06-17 14:40 ` Jan Beulich
2016-06-17 14:44 ` Wei Liu
2016-06-17 14:55 ` Jan Beulich
2016-06-17 14:59 ` Wei Liu
2016-06-17 13:50 ` Andrew Cooper
2016-06-17 14:45 ` Jan Beulich
2016-06-20 9:09 ` Wei Liu
2016-06-20 10:11 ` Jan Beulich
2016-06-20 13:19 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160617133558.GC28116@citrix.com \
--to=wei.liu2@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=cardoe@cardoe.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).