From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH] libxl: fix an error path that uses uninitialised rc in libxl_set_memory_target Date: Wed, 22 Jun 2016 16:29:21 +0100 Message-ID: <20160622152921.GI1790@citrix.com> References: <1465740590-21337-1-git-send-email-wei.liu2@citrix.com> <576AA79402000078000F7AC6@prv-mh.provo.novell.com> <20160622134704.GE1790@citrix.com> <576AB49402000078000F7B56@prv-mh.provo.novell.com> <20160622135934.GF1790@citrix.com> <576AC8F902000078000F7BDB@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFk5r-0004C0-Ct for xen-devel@lists.xenproject.org; Wed, 22 Jun 2016 15:29:31 +0000 Content-Disposition: inline In-Reply-To: <576AC8F902000078000F7BDB@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: George Dunlap , Ian Jackson , Wei Liu , Paulina Szubarczyk , Xen-devel List-Id: xen-devel@lists.xenproject.org T24gV2VkLCBKdW4gMjIsIDIwMTYgYXQgMDk6MjA6NTdBTSAtMDYwMCwgSmFuIEJldWxpY2ggd3Jv dGU6Cj4gPj4+IE9uIDIyLjA2LjE2IGF0IDE1OjU5LCA8d2VpLmxpdTJAY2l0cml4LmNvbT4gd3Jv dGU6Cj4gPiBPbiBXZWQsIEp1biAyMiwgMjAxNiBhdCAwNzo1Mzo1NkFNIC0wNjAwLCBKYW4gQmV1 bGljaCB3cm90ZToKPiA+PiA+Pj4gT24gMjIuMDYuMTYgYXQgMTU6NDcsIDx3ZWkubGl1MkBjaXRy aXguY29tPiB3cm90ZToKPiA+PiA+IE9uIFdlZCwgSnVuIDIyLCAyMDE2IGF0IDA2OjU4OjI4QU0g LTA2MDAsIEphbiBCZXVsaWNoIHdyb3RlOgo+ID4+ID4+ID4+PiBPbiAxMi4wNi4xNiBhdCAxNjow OSwgPHdlaS5saXUyQGNpdHJpeC5jb20+IHdyb3RlOgo+ID4+ID4+ID4gLS0tIGEvdG9vbHMvbGli eGwvbGlieGwuYwo+ID4+ID4+ID4gKysrIGIvdG9vbHMvbGlieGwvbGlieGwuYwo+ID4+ID4+ID4g QEAgLTQ5MjcsMTAgKzQ5MjcsMTIgQEAgcmV0cnlfdHJhbnNhY3Rpb246Cj4gPj4gPj4gPiAgCj4g Pj4gPj4gPiAgICAgIHRhcmdldCA9IGxpYnhsX194c19yZWFkKGdjLCB0LCBHQ1NQUklOVEYoIiVz L21lbW9yeS90YXJnZXQiLCAKPiA+IGRvbXBhdGgpKTsKPiA+PiA+PiA+ICAgICAgaWYgKCF0YXJn ZXQgJiYgIWRvbWlkKSB7Cj4gPj4gPj4gPiAtICAgICAgICBpZiAoIXhzX3RyYW5zYWN0aW9uX2Vu ZChjdHgtPnhzaCwgdCwgMSkpCj4gPj4gPj4gPiArICAgICAgICBpZiAoIXhzX3RyYW5zYWN0aW9u X2VuZChjdHgtPnhzaCwgdCwgMSkpIHsKPiA+PiA+PiA+ICsgICAgICAgICAgICByYyA9IEVSUk9S X0ZBSUw7Cj4gPj4gPj4gCj4gPj4gPj4gSSdtIHNvcnJ5IGZvciBub3RpY2luZyB0aGlzIG9ubHkg bm93IC0gaXMgRVJST1JfRkFJTCB0aGUgcmlnaHQgdGhpbmcKPiA+PiA+PiB0byB1c2UgaGVyZSwg Y29uc2lkZXJpbmcgaG93IHRoaW5ncyB3b3JrZWQgYmVmb3JlIHRoZSBjaGFuZ2UgdGhhdAo+ID4+ ID4+IGludHJvZHVjZWQgdGhlIGlzc3VlIGdldHRpbmcgZml4ZWQgaGVyZT8gSSBoYWQgaW50ZW50 aW9uYWxseSBkZWNpZGVkCj4gPj4gPj4gdG8gdXNlIEVSUk9SX0lOVkFMIGluIHRoZSBwYXRjaCB2 YXJpYW50IEkgZGlkIHN1Ym1pdCAoYXMgYXQgdGhhdAo+ID4+ID4+IHRpbWUgSSB3YXNuJ3QgeWV0 IGF3YXJlIG9mIHRoZSBvdGhlciBmaXggZmxvYXRpbmcgYXJvdW5kIGFscmVhZHkpLgo+ID4+ID4+ IAo+ID4+ID4gCj4gPj4gPiBXaGVuIEkgd3JvdGUgdGhpcyBwYXRjaCwgSSB0aG91Z2h0IHRoZSBy ZXR1cm4gdmFsdWUgc2hvdWxkIGJlIHRpZWQgdG8KPiA+PiA+IHhzX3RyYW5zYWN0aW9uX2VuZC4K PiA+PiAKPiA+PiB4c190cmFuc2FjdGlvbl9lbmQoKSByZXR1cm5pbmcgemVybyBtZWFucyBzdWNj ZXNzIGFmYWljdC4KPiA+PiAKPiA+IAo+ID4gLyogRW5kIGEgdHJhbnNhY3Rpb24uCj4gPiAgKiBJ ZiBhYmFuZG9uIGlzIHRydWUsIHRyYW5zYWN0aW9uIGlzIGRpc2NhcmRlZCBpbnN0ZWFkIG9mIGNv bW1pdHRlZC4KPiA+ICAqIFJldHVybnMgZmFsc2Ugb24gZmFpbHVyZTogaWYgZXJybm8gPT0gRUFH QUlOLCB5b3UgaGF2ZSB0byByZXN0YXJ0Cj4gPiAgKiB0cmFuc2FjdGlvbi4KPiA+ICAqLwo+ID4g Ym9vbCB4c190cmFuc2FjdGlvbl9lbmQoc3RydWN0IHhzX2hhbmRsZSAqaCwgeHNfdHJhbnNhY3Rp b25fdCB0LAo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgYm9vbCBhYm9ydCk7Cj4gPiAKPiA+ IEkgdGhpbmsgeW91IG1pc3JlYWQuCj4gCj4gSW5kZWVkLCBJIGdvdCBtaXNsZWFkIGJ5ICJnb3Rv IG91dF9ub190cmFuc2FjdGlvbiIuIFlldCB0aGF0Cj4gZG9lc24ndCBjaGFuZ2UgdGhlIGRpc2N1 c3Npb24gb2YgdGhlIGVycm9yIC0gb3JpZ2luYWxseSB0aGlzIGRpZG4ndAo+IHJldHVybiAtMSBo ZXJlLCBidXQgKzEgKGkuZS4gcmVmbGVjdGluZyB0aGUgc3Vycm91bmRpbmcgaWYoKSwgbm90Cj4g dGhlIGlubmVyIG9uZSkuCj4gCgpTbyB0aGF0IGNvbWVzIGJhY2sgdG8gdGhlIGludGVudCBvZiBl Y2RjNmZkOCAtLSB0byBmaXggdGhlIG1hZCBzZW1hbnRpY3MKb2YgdGhhdCBmdW5jdGlvbi4gV2Ug ZG9uJ3QgbmVlZCB0byBkdXBsaWNhdGUgd2hhdCBpdCBkaWQgYmVmb3JlLgoKV2VpLgoKPiBKYW4K PiAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1k ZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cDovL2xpc3RzLnhl bi5vcmcveGVuLWRldmVsCg==