From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Bob Liu <bob.liu@oracle.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
roger.pau@citrix.com
Subject: Re: [PATCH] xen-blkfront: save uncompleted reqs in blkfront_resume()
Date: Tue, 28 Jun 2016 15:53:26 -0400 [thread overview]
Message-ID: <20160628195325.GA14723@char.us.oracle.com> (raw)
In-Reply-To: <1467016404-7883-1-git-send-email-bob.liu@oracle.com>
On Mon, Jun 27, 2016 at 04:33:24PM +0800, Bob Liu wrote:
> Uncompleted reqs used to be 'saved and resubmitted' in blkfront_recover() during
> migration, but that's too later after multi-queue introduced.
>
> After a migrate to another host (which may not have multiqueue support), the
> number of rings (block hardware queues) may be changed and the ring and shadow
> structure will also be reallocated.
> So that blkfront_recover() can't 'save and resubmit' the real uncompleted reqs
> because shadow structure has been reallocated.
>
> This patch fixes this issue by moving the 'save and resubmit' logic out of
> blkfront_recover() to earlier place:blkfront_resume().
>
> Signed-off-by: Bob Liu <bob.liu@oracle.com>
Ack-ed and Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Let me run it through some tests and if no regressions found I will
ask Jens to pull it.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-28 19:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1467016404-7883-1-git-send-email-bob.liu@oracle.com>
2016-06-27 13:29 ` [PATCH] xen-blkfront: save uncompleted reqs in blkfront_resume() Bob Liu
2016-06-28 19:53 ` Konrad Rzeszutek Wilk [this message]
2016-06-27 8:33 Bob Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160628195325.GA14723@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=bob.liu@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).