From: Wei Liu <wei.liu2@citrix.com>
To: Rusty Bird <rustybird@openmailbox.org>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH] tools/hotplug: Add native systemd xendriverdomain.service
Date: Thu, 7 Jul 2016 13:04:36 +0100 [thread overview]
Message-ID: <20160707120436.GL416@citrix.com> (raw)
In-Reply-To: <1467516781-12830-1-git-send-email-rustybird@openmailbox.org>
On Sun, Jul 03, 2016 at 03:33:01AM +0000, Rusty Bird wrote:
> Uses ConditionVirtualization=xen, which evaluates to false in dom0 since
> systemd 214 (released 2014-06-11). An alternative would be this line:
> ExecStartPre=/bin/sh -c "! grep -q control_d /proc/xen/capabilities"
>
> (Please rerun autogen.sh)
>
While I understand it might be necessary to have a dedicated service
file for xendriverdomain, I can't seem to be able to figure out the
rationale from the commit message.
After thinking a bit harder, may I suggest commit message like this (and
please correct me if I'm wrong):
We need to have a dedicated service for xendriverdoamin in driver
domain. This patch creates a service file for it. This service is only
relevant to DomU.
The service file uses ConditionVirtualization=xen becuase that evaluates
to false in Dom0 while true in DomU, so that we only starts this service
in DomU.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-07 12:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-03 3:33 [PATCH] tools/hotplug: Add native systemd xendriverdomain.service Rusty Bird
2016-07-07 12:04 ` Wei Liu [this message]
2016-07-07 14:19 ` Rusty Bird
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160707120436.GL416@citrix.com \
--to=wei.liu2@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=rustybird@openmailbox.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).