From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH v5 01/14] libxc: Rework extra module initialisation Date: Thu, 7 Jul 2016 15:55:23 +0100 Message-ID: <20160707145523.GO416@citrix.com> References: <20160622171545.5304-1-anthony.perard@citrix.com> <20160622171545.5304-2-anthony.perard@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20160622171545.5304-2-anthony.perard@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Anthony PERARD Cc: Wei Liu , Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org T24gV2VkLCBKdW4gMjIsIDIwMTYgYXQgMDY6MTU6MzJQTSArMDEwMCwgQW50aG9ueSBQRVJBUkQg d3JvdGU6Cj4gVGhpcyBwYXRjaCB1c2UgeGNfZG9tX2FsbG9jX3NlZ21lbnQoKSB0byBhbGxvY2F0 ZSB0aGUgbWVtb3J5IHNwYWNlIGZvciB0aGUKPiBBQ1BJIG1vZHVsZXMgYW5kIHRoZSBTTUJJT1Mg bW9kdWxlcy4gVGhpcyBpcyB0byByZXBsYWNlIHRoZSBhcmJpdHJhcnkKPiBwbGFjZW1lbnQgb2Yg MU1CICgrIGV4dHJhIGZvciBNQiBhbGlnbmVtZW50KSBhZnRlciB0aGUgaHZtbG9hZGVyIGltYWdl Lgo+IAo+IFRoaXMgcGF0Y2ggY2FuIGhlbHAgaWYgb25lIGFkZCBleHRyYSBBQ1BJIHRhYmxlIGFu ZCBodm1sb2FkZXIgY29udGFpbgo+IE9WTUYgKE9WTUYgaXMgYSAyTUIgYmluYXJ5KSwgYXMgaW4g dGhhdCBjYXNlIHRoZSBleHRyYSBBQ1BJIHRhYmxlIGNvdWxkCj4gZWFzaWx5IGJlIGxvYWRlZCBw YXN0IHRoZSBhZGRyZXNzIDRNQiwgYnV0IGh2bWxvYWRlciB1c2UgYSByYW5nZSBvZgo+IG1lbW9y eSBmcm9tIDRNQiB0byAxME1CIHRvIHBlcmZvcm0gdGVzdHMgYW5kIGluIHRoZSBwcm9jZXNzLCBj bGVhcnMgdGhlCj4gbWVtb3J5LCBiZWZvcmUgbG9hZGluZyB0aGUgbW9kdWxlcy4KPiAKPiBTaWdu ZWQtb2ZmLWJ5OiBBbnRob255IFBFUkFSRCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT4KPiAt LS0KPiBDaGFuZ2VzIGluIFY1Ogo+IC0gcmV3cml0ZSBwYXRjaCBkZXNjcmlwdGlvbgo+IAo+IENo YW5nZXMgaW4gVjQ6Cj4gLSBjaGVjayB0aGF0IGd1ZXN0X2FkZHJfb3V0IGhhdmUgYSByZWFzb25h YmxlIHZhbHVlLgo+IAo+IE5ldyBwYXRjaCBpbiBWMy4KPiAtLS0KPiAgdG9vbHMvbGlieGMveGNf ZG9tX2h2bWxvYWRlci5jIHwgMTMxICsrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAzOCBpbnNlcnRpb25zKCspLCA5MyBkZWxldGlvbnMo LSkKPiAKPiBkaWZmIC0tZ2l0IGEvdG9vbHMvbGlieGMveGNfZG9tX2h2bWxvYWRlci5jIGIvdG9v bHMvbGlieGMveGNfZG9tX2h2bWxvYWRlci5jCj4gaW5kZXggMzMwZDVlOC4uZGE4Yjk5NSAxMDA2 NDQKPiAtLS0gYS90b29scy9saWJ4Yy94Y19kb21faHZtbG9hZGVyLmMKPiArKysgYi90b29scy9s aWJ4Yy94Y19kb21faHZtbG9hZGVyLmMKPiBAQCAtMTI5LDk4ICsxMjksNTIgQEAgc3RhdGljIGVs Zl9lcnJvcnN0YXR1cyB4Y19kb21fcGFyc2VfaHZtX2tlcm5lbChzdHJ1Y3QgeGNfZG9tX2ltYWdl ICpkb20pCj4gICAgICByZXR1cm4gcmM7Cj4gIH0KPiAgCj4gLXN0YXRpYyBpbnQgbW9kdWxlc19p bml0KHN0cnVjdCB4Y19kb21faW1hZ2UgKmRvbSwKPiAtICAgICAgICAgICAgICAgICAgICAgICAg dWludDY0X3QgdmVuZCwgc3RydWN0IGVsZl9iaW5hcnkgKmVsZiwKPiAtICAgICAgICAgICAgICAg ICAgICAgICAgdWludDY0X3QgKm1zdGFydF9vdXQsIHVpbnQ2NF90ICptZW5kX291dCkKPiArc3Rh dGljIGludCBtb2R1bGVfaW5pdF9vbmUoc3RydWN0IHhjX2RvbV9pbWFnZSAqZG9tLAo+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgeGNfaHZtX2Zpcm13YXJlX21vZHVsZSAqbW9k dWxlLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICBjaGFyICpuYW1lKQo+ICB7Cj4gLSNk ZWZpbmUgTU9EVUxFX0FMSUdOIDFVTCA8PCA3Cj4gLSNkZWZpbmUgTUJfQUxJR04gICAgIDFVTCA8 PCAyMAo+IC0jZGVmaW5lIE1LQUxJR04oeCwgYSkgKCgodWludDY0X3QpKHgpICsgKGEpIC0gMSkg JiB+KHVpbnQ2NF90KSgoYSkgLSAxKSkKPiAtICAgIHVpbnQ2NF90IHRvdGFsX2xlbiA9IDAsIG9m ZnNldDEgPSAwOwo+ICsgICAgc3RydWN0IHhjX2RvbV9zZWcgc2VnOwo+ICsgICAgdm9pZCAqZGVz dDsKPiAgCj4gLSAgICBpZiAoIGRvbS0+YWNwaV9tb2R1bGUubGVuZ3RoID09IDAgJiYgZG9tLT5z bWJpb3NfbW9kdWxlLmxlbmd0aCA9PSAwICkKPiAtICAgICAgICByZXR1cm4gMDsKPiAtCj4gLSAg ICAvKiBGaW5kIHRoZSB0b3RhbCBsZW5ndGggZm9yIHRoZSBmaXJtd2FyZSBtb2R1bGVzIHdpdGgg YSByZWFzb25hYmxlIGxhcmdlCj4gLSAgICAgKiBhbGlnbm1lbnQgc2l6ZSB0byBhbGlnbiBlYWNo IHRoZSBtb2R1bGVzLgo+IC0gICAgICovCj4gLSAgICB0b3RhbF9sZW4gPSBNS0FMSUdOKGRvbS0+ YWNwaV9tb2R1bGUubGVuZ3RoLCBNT0RVTEVfQUxJR04pOwo+IC0gICAgb2Zmc2V0MSA9IHRvdGFs X2xlbjsKPiAtICAgIHRvdGFsX2xlbiArPSBNS0FMSUdOKGRvbS0+c21iaW9zX21vZHVsZS5sZW5n dGgsIE1PRFVMRV9BTElHTik7Cj4gLQo+IC0gICAgLyogV2FudCB0byBwbGFjZSB0aGUgbW9kdWxl cyAxTWIrY2hhbmdlIGJlaGluZCB0aGUgbG9hZGVyIGltYWdlLiAqLwo+IC0gICAgKm1zdGFydF9v dXQgPSBNS0FMSUdOKGVsZi0+cGVuZCwgTUJfQUxJR04pICsgKE1CX0FMSUdOKTsKPiAtICAgICpt ZW5kX291dCA9ICptc3RhcnRfb3V0ICsgdG90YWxfbGVuOwo+IC0KPiAtICAgIGlmICggKm1lbmRf b3V0ID4gdmVuZCApCj4gLSAgICAgICAgcmV0dXJuIC0xOwo+IC0KPiAtICAgIGlmICggZG9tLT5h Y3BpX21vZHVsZS5sZW5ndGggIT0gMCApCj4gLSAgICAgICAgZG9tLT5hY3BpX21vZHVsZS5ndWVz dF9hZGRyX291dCA9ICptc3RhcnRfb3V0Owo+IC0gICAgaWYgKCBkb20tPnNtYmlvc19tb2R1bGUu bGVuZ3RoICE9IDAgKQo+IC0gICAgICAgIGRvbS0+c21iaW9zX21vZHVsZS5ndWVzdF9hZGRyX291 dCA9ICptc3RhcnRfb3V0ICsgb2Zmc2V0MTsKPiArICAgIGlmICggbW9kdWxlLT5sZW5ndGggKQo+ ICsgICAgewo+ICsgICAgICAgIGlmICggeGNfZG9tX2FsbG9jX3NlZ21lbnQoZG9tLCAmc2VnLCBu YW1lLCAwLCBtb2R1bGUtPmxlbmd0aCkgKQo+ICsgICAgICAgICAgICBnb3RvIGVycjsKPiArICAg ICAgICBkZXN0ID0geGNfZG9tX3NlZ190b19wdHIoZG9tLCAmc2VnKTsKPiArICAgICAgICBpZiAo IGRlc3QgPT0gTlVMTCApCj4gKyAgICAgICAgewo+ICsgICAgICAgICAgICBET01QUklOVEYoIiVz OiB4Y19kb21fc2VnX3RvX3B0cihkb20sICZzZWcpID0+IE5VTEwiLAo+ICsgICAgICAgICAgICAg ICAgICAgICAgX19GVU5DVElPTl9fKTsKPiArICAgICAgICAgICAgZ290byBlcnI7Cj4gKyAgICAg ICAgfQo+ICsgICAgICAgIG1lbWNweShkZXN0LCBtb2R1bGUtPmRhdGEsIG1vZHVsZS0+bGVuZ3Ro KTsKPiArICAgICAgICBtb2R1bGUtPmd1ZXN0X2FkZHJfb3V0ID0gc2VnLnZzdGFydDsKPiArICAg ICAgICBpZiAoIG1vZHVsZS0+Z3Vlc3RfYWRkcl9vdXQgPiBVSU5UMzJfTUFYIHx8Cj4gKyAgICAg ICAgICAgICBtb2R1bGUtPmd1ZXN0X2FkZHJfb3V0ICsgbW9kdWxlLT5sZW5ndGggPiBVSU5UMzJf TUFYICkKPiArICAgICAgICB7Cj4gKyAgICAgICAgICAgIERPTVBSSU5URigiJXM6IE1vZHVsZSAl cyB3b3VsZCBiZSBsb2FkZWQgYWJyb3ZlIDRHQiIsCj4gKyAgICAgICAgICAgICAgICAgICAgICBf X0ZVTkNUSU9OX18sIG5hbWUpOwo+ICsgICAgICAgICAgICBnb3RvIGVycjsKPiArICAgICAgICB9 CgpPbmUgcXVlc3Rpb246CgpDYW4gdGhpcyBjaGVjayBhbHNvIGFjY291bnQgZm9yIE1NSU8gaG9s ZSBiZWxvdyA0Rz8gTWF5YmUgdXNlCmRvbS0+bW1pb19zaXplPwoKT3RoZXIgdGhhbiB0aGlzLCB0 aGlzIHBhdGNoIGxvb2tzIGdvb2QuCgpXZWkuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0 cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK