From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH v5 05/14] libxl: Load guest BIOS from file Date: Thu, 7 Jul 2016 15:55:37 +0100 Message-ID: <20160707145537.GR416@citrix.com> References: <20160622171545.5304-1-anthony.perard@citrix.com> <20160622171545.5304-6-anthony.perard@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20160622171545.5304-6-anthony.perard@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Anthony PERARD Cc: Wei Liu , Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org T24gV2VkLCBKdW4gMjIsIDIwMTYgYXQgMDY6MTU6MzZQTSArMDEwMCwgQW50aG9ueSBQRVJBUkQg d3JvdGU6Cj4gVGhlIHBhdGggdG8gdGhlIEJJT1MgYmxvYiBjYW4gYmUgb3ZlcnJpZGVuIGJ5IHRo ZSB4bCdzCj4gYmlvc19wYXRoX292ZXJyaWRlIG9wdGlvbiwgb3IgcHJvdmlkZWQgYnkgdS5odm0u Ymlvc19maXJtd2FyZSBpbiB0aGUKPiBkb21haW5fYnVpbGRfaW5mbyBzdHJ1Y3QgYnkgb3RoZXIg bGlieGwgdXNlci4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBBbnRob255IFBFUkFSRCA8YW50aG9ueS5w ZXJhcmRAY2l0cml4LmNvbT4KPiAKPiAtLS0KPiBDaGFuZ2VzIGluIFY1Ogo+IC0gbWFuIHBhZ2Us IHVzZSBCPD4gdG8gaGlnaGxpZ2h0IGNvbmZpZyBvcHRpb24gaW4gZGVzY3JpcHRpb24uCj4gLSBy ZW5hbWUgY29uZmlnIG9wdGlvbiBmcm9tIGBiaW9zX292ZXJyaWRlYCB0byBgYmlvc19wYXRoX292 ZXJyaWRlYAo+IC0gc3RvcmUgbGlieGxfcmVhZF9maWxlX2NvbnRlbnRzKCkgcmV0dXJuIHZhbHVl IGludG8gciBpbnN0ZWFkIG9mIGUKPiAgIChqdXN0IHJlbmFtZWQgdGhlIHZhcmlhYmxlKQo+IC0g cmVuYW1lIGRvbWFpbl9idWlsZF9pbmZvLnUuaHZtLmJpb3NfZmlybXdhcmUgdG8gc3lzdGVtX2Zp cm13YXJlCj4gCj4gQ2hhbmdlcyBpbiBWNDoKPiAtIHVwZGF0aW5nIG1hbiBwYWdlIHRvIGhhdmUg Ymlvc19vdmVycmlkZSBkZXNjcmliZWQuCj4gLSByZXR1cm4gRVJST1JfSU5WQUwgaW4gbGlieGxf X2xvYWRfaHZtX2Zpcm13YXJlX21vZHVsZSB3aGVuIHRoZSBmaWxlIGlzCj4gICBlbXB0eS4KPiAK PiBDaGFuZ2VzIGluIFYzOgo+IC0gbW92ZSBzZWFiaW9zX3BhdGggYW5kIG92bWZfcGF0aCB0byBs aWJ4bF9wYXRoLmMgKHdpdGggcmVuYW1pbmcpCj4gLSBmaXggc29tZSBjb2Rpbmcgc3R5bGUKPiAt IHdhcm4gZm9yIGVtcHR5IGZpbGUKPiAtIHJlbW92ZSByb21iaW9zIHN0dWZmICh3aWxsIHN0aWxs IGJlIGJ1aWx0LWluIGh2bWxvYWRlcikKPiAtIHJlbmFtZSBmaWVsZCBiaW9zX2ZpbGVuYW1lIGlu IGRvbWFpbl9idWlsZF9pbmZvIHRvIGJpb3NfZmlybXdhcmUgdG8KPiAgIGZvbGxvdyBuYW1pbmcg b2YgYWNwaSBhbmQgc21iaW9zLgo+IC0gbG9nIGFuIGVycm9yIGFmdGVyIGxpYnhsX3JlYWRfZmls ZV9jb250ZW50cygpIG9ubHkgd2hlbiBpdCByZXR1cm4gRU5PRU5UCj4gLSByZXR1cm4gYW4gZXJy b3Igb24gZW1wdHkgZmlsZS4KPiAtIGFkZGVkICNkZWZpbmUgTElCWExfSEFWRV9CVUlMRElORk9f SFZNX0JJT1NfRklSTVdBUkUKPiAtLS0KPiAgZG9jcy9tYW4veGwuY2ZnLnBvZC41LmluICAgICB8 ICA5ICsrKysrKysKPiAgdG9vbHMvbGlieGwvbGlieGwuaCAgICAgICAgICB8ICA4ICsrKysrKysK PiAgdG9vbHMvbGlieGwvbGlieGxfZG9tLmMgICAgICB8IDU3ICsrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrCj4gIHRvb2xzL2xpYnhsL2xpYnhsX2ludGVybmFsLmgg fCAgMiArKwo+ICB0b29scy9saWJ4bC9saWJ4bF9wYXRocy5jICAgIHwgMTAgKysrKysrKysKPiAg dG9vbHMvbGlieGwvbGlieGxfdHlwZXMuaWRsICB8ICAxICsKPiAgdG9vbHMvbGlieGwveGxfY21k aW1wbC5jICAgICB8IDExICsrKysrKy0tLQo+ICA3IGZpbGVzIGNoYW5nZWQsIDk1IGluc2VydGlv bnMoKyksIDMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RvY3MvbWFuL3hsLmNmZy5w b2QuNS5pbiBiL2RvY3MvbWFuL3hsLmNmZy5wb2QuNS5pbgo+IGluZGV4IDNiYjI3ZDAuLmE2ODVi ODMgMTAwNjQ0Cj4gLS0tIGEvZG9jcy9tYW4veGwuY2ZnLnBvZC41LmluCj4gKysrIGIvZG9jcy9t YW4veGwuY2ZnLnBvZC41LmluCj4gQEAgLTEyMTIsNiArMTIxMiwxNSBAQCBSZXF1aXJlcyBkZXZp Y2VfbW9kZWxfdmVyc2lvbj1xZW11LXhlbi4KPiAgCj4gID1iYWNrCj4gIAo+ICs9aXRlbSBCPGJp b3NfcGF0aF9vdmVycmlkZT0iUEFUSCI+Cj4gKwo+ICtPdmVycmlkZSB0aGUgcGF0aCB0byB0aGUg YmxvYiB0byBiZSB1c2VkIGFzIEJJT1MuIFRoZSBibG9iIHByb3ZpZGVkIGhlcmUgTVVTVAo+ICti ZSBjb25zaXN0ZW50IHdpdGggdGhlIEI8Ymlvcz0+IHdoaWNoIHlvdSBoYXZlIHNwZWNpZmllZC4g WW91IHNob3VsZCBub3QKPiArbm9ybWFsbHkgbmVlZCB0byBzcGVjaWZ5IHRoaXMgb3B0aW9uLgo+ ICsKPiArVGhpcyBvcHRpb25zIGRvZXMgbm90IGhhdmUgYW55IGVmZmVjdCBpZiB1c2luZyBCPGJp b3M9InJvbWJpb3MiPiBvcgo+ICtCPGRldmljZV9tb2RlbF92ZXJzaW9uPSJxZW11LXhlbi10cmFk aXRpb25hbCI+Lgo+ICsKPiAgPWl0ZW0gQjxwYWU9Qk9PTEVBTj4KPiAgCj4gIEhpZGUgb3IgZXhw b3NlIHRoZSBJQTMyIFBoeXNpY2FsIEFkZHJlc3MgRXh0ZW5zaW9ucy4gVGhlc2UgZXh0ZW5zaW9u cwo+IGRpZmYgLS1naXQgYS90b29scy9saWJ4bC9saWJ4bC5oIGIvdG9vbHMvbGlieGwvbGlieGwu aAo+IGluZGV4IDJjMGY4NjguLjJiMWY2NzggMTAwNjQ0Cj4gLS0tIGEvdG9vbHMvbGlieGwvbGli eGwuaAo+ICsrKyBiL3Rvb2xzL2xpYnhsL2xpYnhsLmgKPiBAQCAtOTI4LDYgKzkyOCwxNCBAQCB2 b2lkIGxpYnhsX21hY19jb3B5KGxpYnhsX2N0eCAqY3R4LCBsaWJ4bF9tYWMgKmRzdCwgbGlieGxf bWFjICpzcmMpOwo+ICAjZGVmaW5lIExJQlhMX0hBVkVfQ0hFQ0tQT0lOVEVEX1NUUkVBTSAxCj4g IAo+ICAvKgo+ICsgKiBMSUJYTF9IQVZFX0JVSUxESU5GT19IVk1fU1lTVEVNX0ZJUk1XQVJFCj4g KyAqCj4gKyAqIGxpYnhsX2RvbWFpbl9idWlsZF9pbmZvIGhhcyB1Lmh2bS5zeXN0ZW1fZmlybXdh cmUgZmllbGQgd2hpY2ggY2FuIGJlIHVzZQo+ICsgKiB0byBwcm92aWRlIGEgZGlmZmVyZW50IGZp cm13YXJlIGJsb2IgKGxpa2UgU2VhQklPUyBvciBPVk1GKS4KPiArICovCj4gKyNkZWZpbmUgTElC WExfSEFWRV9CVUlMRElORk9fSFZNX1NZU1RFTV9GSVJNV0FSRQo+ICsKPiArLyoKPiAgICogRVJS T1JfUkVNVVNfWFhYIGVycm9yIGNvZGUgb25seSBleGlzdHMgZnJvbSBYZW4gNC41LCBYZW4gNC42 IGFuZCBpdAo+ICAgKiBpcyBjaGFuZ2VkIHRvIEVSUk9SX0NIRUNLUE9JTlRfWFhYIGluIFhlbiA0 LjcKPiAgICovCj4gZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhsL2xpYnhsX2RvbS5jIGIvdG9vbHMv bGlieGwvbGlieGxfZG9tLmMKPiBpbmRleCBlYzI5MDYwLi5jMzQxYTI5IDEwMDY0NAo+IC0tLSBh L3Rvb2xzL2xpYnhsL2xpYnhsX2RvbS5jCj4gKysrIGIvdG9vbHMvbGlieGwvbGlieGxfZG9tLmMK PiBAQCAtODYyLDYgKzg2MiwzOCBAQCBlcnI6Cj4gICAgICByZXR1cm4gcmV0Owo+ICB9Cj4gIAo+ ICtzdGF0aWMgaW50IGxpYnhsX19sb2FkX2h2bV9maXJtd2FyZV9tb2R1bGUobGlieGxfX2djICpn YywKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IGNo YXIgKmZpbGVuYW1lLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgY29uc3QgY2hhciAqd2hhdCwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHN0cnVjdCB4Y19odm1fZmlybXdhcmVfbW9kdWxlICptKQo+ICt7Cj4gKyAgICBp bnQgZGF0YWxlbiA9IDA7Cj4gKyAgICB2b2lkICpkYXRhID0gTlVMTDsKPiArICAgIGludCByOwo+ ICsKPiArICAgIExPRyhERUJVRywgIkxvYWRpbmcgJXM6ICVzIiwgd2hhdCwgZmlsZW5hbWUpOwo+ ICsgICAgciA9IGxpYnhsX3JlYWRfZmlsZV9jb250ZW50cyhDVFgsIGZpbGVuYW1lLCAmZGF0YSwg JmRhdGFsZW4pOwo+ICsgICAgaWYgKHIpIHsKPiArICAgICAgICAvKgo+ICsgICAgICAgICAqIFBy aW50IGEgbWVzc2FnZSBvbmx5IG9uIEVOT0VOVCwgb3RoZXIgZXJyb3JzIGFyZSBsb2dnZWQgYnkg dGhlCj4gKyAgICAgICAgICogZnVuY3Rpb24gbGlieGxfcmVhZF9maWxlX2NvbnRlbnRzKCkuCj4g KyAgICAgICAgICovCj4gKyAgICAgICAgaWYgKHIgPT0gRU5PRU5UKQo+ICsgICAgICAgICAgICBM T0dFVihFUlJPUiwgciwgImZhaWxlZCB0byByZWFkICVzIGZpbGUiLCB3aGF0KTsKPiArICAgICAg ICByZXR1cm4gRVJST1JfRkFJTDsKPiArICAgIH0KPiArICAgIGxpYnhsX19wdHJfYWRkKGdjLCBk YXRhKTsKPiArICAgIGlmIChkYXRhbGVuKSB7Cj4gKyAgICAgICAgLyogT25seSBhY2NlcHQgbm9u LWVtcHR5IGZpbGVzICovCj4gKyAgICAgICAgbS0+ZGF0YSA9IGRhdGE7Cj4gKyAgICAgICAgbS0+ bGVuZ3RoID0gZGF0YWxlbjsKPiArICAgIH0gZWxzZSB7Cj4gKyAgICAgICAgTE9HKEVSUk9SLCAi ZmlsZSAlcyBmb3IgJXMgaXMgZW1wdHkiLCBmaWxlbmFtZSwgd2hhdCk7Cj4gKyAgICAgICAgcmV0 dXJuIEVSUk9SX0lOVkFMOwo+ICsgICAgfQo+ICsgICAgcmV0dXJuIDA7Cj4gK30KPiArCgpQbGVh c2UgdXNlIGdvdG8gc3R5bGUgZXJyb3IgaGFuZGxpbmcgdG8gYmUgY29uc2lzdGVudCB3aXRoIG90 aGVyIGNvZGUuCgpXZWkuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0 dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK