From: Wei Liu <wei.liu2@citrix.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: hangaohuai@huawei.com, sstabellini@kernel.org,
Wei Liu <wei.liu2@citrix.com>,
ian.jackson@eu.citrix.com, peter.huangpeng@huawei.com,
xen-devel@lists.xen.org, julien.grall@arm.com,
shannon.zhao@linaro.org, Shannon Zhao <zhaoshenglong@huawei.com>
Subject: Re: [PATCH v3 01/17] libxl/arm: Factor out codes for generating DTB
Date: Thu, 7 Jul 2016 17:08:39 +0100 [thread overview]
Message-ID: <20160707160839.GC416@citrix.com> (raw)
In-Reply-To: <0f2f40e2-45d1-5144-d9cc-b23c12beb24b@oracle.com>
On Thu, Jul 07, 2016 at 11:48:49AM -0400, Boris Ostrovsky wrote:
> On 07/07/2016 11:41 AM, Wei Liu wrote:
> > On Tue, Jul 05, 2016 at 11:12:31AM +0800, Shannon Zhao wrote:
> >> From: Shannon Zhao <shannon.zhao@linaro.org>
> >>
> >> Factor out codes for generating DTB to prepare for adding ACPI tables
> >> generation codes.
> >>
> >> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
> >> Acked-by: Wei Liu <wei.liu2@citrix.com>
> >> ---
> >> tools/libxl/libxl_arm.c | 18 ++++++++++++------
> >> 1 file changed, 12 insertions(+), 6 deletions(-)
> >>
> >> diff --git a/tools/libxl/libxl_arm.c b/tools/libxl/libxl_arm.c
> >> index ddd80aa..4a57dd7 100644
> >> --- a/tools/libxl/libxl_arm.c
> >> +++ b/tools/libxl/libxl_arm.c
> >> @@ -747,10 +747,9 @@ static int copy_partial_fdt(libxl__gc *gc, void *fdt, void *pfdt)
> >>
> >> #define FDT_MAX_SIZE (1<<20)
> >>
> >> -int libxl__arch_domain_init_hw_description(libxl__gc *gc,
> >> - libxl_domain_build_info *info,
> >> - libxl__domain_build_state *state,
> >> - struct xc_dom_image *dom)
> >> +static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_build_info *info,
> >> + libxl__domain_build_state *state,
> >> + struct xc_dom_image *dom)
> > I've queued this up for committing and will fix the indentation as I go
> > along.
>
>
> I don't think this can be ready for committing since it sits on top of
> my not-yet-reviewed series (which is pretty much guaranteed to require a
> new spin).
>
I thought this patch posted long time ago. But things might have
changed. I will wait.
>
> -boris
>
>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-07 16:08 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 3:12 [PATCH v3 00/17] Xen ARM DomU ACPI support Shannon Zhao
2016-07-05 3:12 ` [PATCH v3 01/17] libxl/arm: Factor out codes for generating DTB Shannon Zhao
2016-07-07 15:41 ` Wei Liu
2016-07-07 15:48 ` Boris Ostrovsky
2016-07-07 16:06 ` Julien Grall
2016-07-07 16:09 ` Wei Liu
2016-07-07 16:12 ` Boris Ostrovsky
2016-07-07 16:15 ` Julien Grall
2016-07-07 16:16 ` Wei Liu
2016-07-07 16:08 ` Wei Liu [this message]
2016-07-05 3:12 ` [PATCH v3 02/17] libxc: Add placeholders for ACPI tables blob and size Shannon Zhao
2016-07-07 15:42 ` Wei Liu
2016-07-05 3:12 ` [PATCH v3 03/17] libxl/arm: Add a configuration option for ARM DomU ACPI Shannon Zhao
2016-07-07 15:48 ` Wei Liu
2016-07-05 3:12 ` [PATCH v3 04/17] libxl/arm: prepare for constructing ACPI tables Shannon Zhao
2016-07-07 15:50 ` Wei Liu
2016-07-12 7:05 ` Shannon Zhao
2016-07-05 3:12 ` [PATCH v3 05/17] libxl/arm: Generate static ACPI DSDT table Shannon Zhao
2016-07-07 15:52 ` Wei Liu
2016-07-12 3:50 ` Shannon Zhao
2016-07-12 11:38 ` Wei Liu
2016-07-12 14:49 ` Shannon Zhao
2016-07-05 3:12 ` [PATCH v3 06/17] libxl/arm: Estimate the size of ACPI tables Shannon Zhao
2016-07-07 16:07 ` Wei Liu
2016-07-07 16:39 ` Julien Grall
2016-07-08 10:45 ` Wei Liu
2016-07-05 3:12 ` [PATCH v3 07/17] libxl/arm: Construct ACPI RSDP table Shannon Zhao
2016-07-07 22:43 ` Boris Ostrovsky
2016-07-08 3:31 ` Shannon Zhao
2016-07-05 3:12 ` [PATCH v3 08/17] libxl/arm: Construct ACPI XSDT table Shannon Zhao
2016-07-05 3:12 ` [PATCH v3 09/17] libxl/arm: Construct ACPI GTDT table Shannon Zhao
2016-07-05 3:12 ` [PATCH v3 10/17] libxl/arm: Factor MPIDR computing codes out as a helper Shannon Zhao
2016-07-05 3:12 ` [PATCH v3 11/17] libxl/arm: Construct ACPI MADT table Shannon Zhao
2016-07-07 16:11 ` Wei Liu
2016-07-07 16:46 ` Julien Grall
2016-07-05 3:12 ` [PATCH v3 12/17] libxl/arm: Construct ACPI FADT table Shannon Zhao
2016-07-05 3:12 ` [PATCH v3 13/17] libxl/arm: Construct ACPI DSDT table Shannon Zhao
2016-07-05 3:12 ` [PATCH v3 14/17] libxl/arm: Factor finalise_one_memory_node as a gerneric function Shannon Zhao
2016-07-05 3:12 ` [PATCH v3 15/17] libxl/arm: Add ACPI module Shannon Zhao
2016-07-05 3:12 ` [PATCH v3 16/17] libxc/xc_dom_core: Copy ACPI tables to guest space Shannon Zhao
2016-07-05 3:12 ` [PATCH v3 17/17] libxl/arm: Initialize domain param HVM_PARAM_CALLBACK_IRQ Shannon Zhao
2016-07-07 16:15 ` Wei Liu
2016-07-07 16:57 ` Julien Grall
2016-07-08 3:41 ` Shannon Zhao
2016-07-08 10:47 ` Wei Liu
2016-07-05 10:32 ` [PATCH v3 00/17] Xen ARM DomU ACPI support Julien Grall
2016-07-05 14:09 ` Shannon Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160707160839.GC416@citrix.com \
--to=wei.liu2@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=hangaohuai@huawei.com \
--cc=ian.jackson@eu.citrix.com \
--cc=julien.grall@arm.com \
--cc=peter.huangpeng@huawei.com \
--cc=shannon.zhao@linaro.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).