From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH v5 01/14] libxc: Rework extra module
	initialisation
Date: Fri, 8 Jul 2016 12:29:36 +0100
Message-ID: <20160708112935.GR416@citrix.com>
References: <20160622171545.5304-1-anthony.perard@citrix.com>
 <20160622171545.5304-2-anthony.perard@citrix.com>
 <20160707145523.GO416@citrix.com>
 <20160708105207.GE1729@perard.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <20160708105207.GE1729@perard.uk.xensource.com>
List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

T24gRnJpLCBKdWwgMDgsIDIwMTYgYXQgMTE6NTI6MDhBTSArMDEwMCwgQW50aG9ueSBQRVJBUkQg
d3JvdGU6Cj4gT24gVGh1LCBKdWwgMDcsIDIwMTYgYXQgMDM6NTU6MjNQTSArMDEwMCwgV2VpIExp
dSB3cm90ZToKPiA+IE9uIFdlZCwgSnVuIDIyLCAyMDE2IGF0IDA2OjE1OjMyUE0gKzAxMDAsIEFu
dGhvbnkgUEVSQVJEIHdyb3RlOgo+ID4gPiBUaGlzIHBhdGNoIHVzZSB4Y19kb21fYWxsb2Nfc2Vn
bWVudCgpIHRvIGFsbG9jYXRlIHRoZSBtZW1vcnkgc3BhY2UgZm9yIHRoZQo+ID4gPiBBQ1BJIG1v
ZHVsZXMgYW5kIHRoZSBTTUJJT1MgbW9kdWxlcy4gVGhpcyBpcyB0byByZXBsYWNlIHRoZSBhcmJp
dHJhcnkKPiA+ID4gcGxhY2VtZW50IG9mIDFNQiAoKyBleHRyYSBmb3IgTUIgYWxpZ25lbWVudCkg
YWZ0ZXIgdGhlIGh2bWxvYWRlciBpbWFnZS4KPiA+ID4gCj4gPiA+IFRoaXMgcGF0Y2ggY2FuIGhl
bHAgaWYgb25lIGFkZCBleHRyYSBBQ1BJIHRhYmxlIGFuZCBodm1sb2FkZXIgY29udGFpbgo+ID4g
PiBPVk1GIChPVk1GIGlzIGEgMk1CIGJpbmFyeSksIGFzIGluIHRoYXQgY2FzZSB0aGUgZXh0cmEg
QUNQSSB0YWJsZSBjb3VsZAo+ID4gPiBlYXNpbHkgYmUgbG9hZGVkIHBhc3QgdGhlIGFkZHJlc3Mg
NE1CLCBidXQgaHZtbG9hZGVyIHVzZSBhIHJhbmdlIG9mCj4gPiA+IG1lbW9yeSBmcm9tIDRNQiB0
byAxME1CIHRvIHBlcmZvcm0gdGVzdHMgYW5kIGluIHRoZSBwcm9jZXNzLCBjbGVhcnMgdGhlCj4g
PiA+IG1lbW9yeSwgYmVmb3JlIGxvYWRpbmcgdGhlIG1vZHVsZXMuCj4gPiA+IAo+ID4gPiBTaWdu
ZWQtb2ZmLWJ5OiBBbnRob255IFBFUkFSRCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT4KPiA+
ID4gLS0tCj4gPiA+IENoYW5nZXMgaW4gVjU6Cj4gPiA+IC0gcmV3cml0ZSBwYXRjaCBkZXNjcmlw
dGlvbgo+ID4gPiAKPiA+ID4gQ2hhbmdlcyBpbiBWNDoKPiA+ID4gLSBjaGVjayB0aGF0IGd1ZXN0
X2FkZHJfb3V0IGhhdmUgYSByZWFzb25hYmxlIHZhbHVlLgo+ID4gPiAKPiA+ID4gTmV3IHBhdGNo
IGluIFYzLgo+ID4gPiAtLS0KPiA+ID4gIHRvb2xzL2xpYnhjL3hjX2RvbV9odm1sb2FkZXIuYyB8
IDEzMSArKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gPiAgMSBm
aWxlIGNoYW5nZWQsIDM4IGluc2VydGlvbnMoKyksIDkzIGRlbGV0aW9ucygtKQo+ID4gPiAKPiA+
ID4gZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhjL3hjX2RvbV9odm1sb2FkZXIuYyBiL3Rvb2xzL2xp
YnhjL3hjX2RvbV9odm1sb2FkZXIuYwo+ID4gPiBpbmRleCAzMzBkNWU4Li5kYThiOTk1IDEwMDY0
NAo+ID4gPiAtLS0gYS90b29scy9saWJ4Yy94Y19kb21faHZtbG9hZGVyLmMKPiA+ID4gKysrIGIv
dG9vbHMvbGlieGMveGNfZG9tX2h2bWxvYWRlci5jCj4gPiA+IEBAIC0xMjksOTggKzEyOSw1MiBA
QCBzdGF0aWMgZWxmX2Vycm9yc3RhdHVzIHhjX2RvbV9wYXJzZV9odm1fa2VybmVsKHN0cnVjdCB4
Y19kb21faW1hZ2UgKmRvbSkKPiA+ID4gICAgICByZXR1cm4gcmM7Cj4gPiA+ICB9Cj4gPiA+ICAK
PiA+ID4gLXN0YXRpYyBpbnQgbW9kdWxlc19pbml0KHN0cnVjdCB4Y19kb21faW1hZ2UgKmRvbSwK
PiA+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQ2NF90IHZlbmQsIHN0cnVjdCBlbGZf
YmluYXJ5ICplbGYsCj4gPiA+IC0gICAgICAgICAgICAgICAgICAgICAgICB1aW50NjRfdCAqbXN0
YXJ0X291dCwgdWludDY0X3QgKm1lbmRfb3V0KQo+ID4gPiArc3RhdGljIGludCBtb2R1bGVfaW5p
dF9vbmUoc3RydWN0IHhjX2RvbV9pbWFnZSAqZG9tLAo+ID4gPiArICAgICAgICAgICAgICAgICAg
ICAgICAgICAgc3RydWN0IHhjX2h2bV9maXJtd2FyZV9tb2R1bGUgKm1vZHVsZSwKPiA+ID4gKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgIGNoYXIgKm5hbWUpCj4gPiA+ICB7Cj4gPiA+IC0jZGVm
aW5lIE1PRFVMRV9BTElHTiAxVUwgPDwgNwo+ID4gPiAtI2RlZmluZSBNQl9BTElHTiAgICAgMVVM
IDw8IDIwCj4gPiA+IC0jZGVmaW5lIE1LQUxJR04oeCwgYSkgKCgodWludDY0X3QpKHgpICsgKGEp
IC0gMSkgJiB+KHVpbnQ2NF90KSgoYSkgLSAxKSkKPiA+ID4gLSAgICB1aW50NjRfdCB0b3RhbF9s
ZW4gPSAwLCBvZmZzZXQxID0gMDsKPiA+ID4gKyAgICBzdHJ1Y3QgeGNfZG9tX3NlZyBzZWc7Cj4g
PiA+ICsgICAgdm9pZCAqZGVzdDsKPiA+ID4gIAo+ID4gPiAtICAgIGlmICggZG9tLT5hY3BpX21v
ZHVsZS5sZW5ndGggPT0gMCAmJiBkb20tPnNtYmlvc19tb2R1bGUubGVuZ3RoID09IDAgKQo+ID4g
PiAtICAgICAgICByZXR1cm4gMDsKPiA+ID4gLQo+ID4gPiAtICAgIC8qIEZpbmQgdGhlIHRvdGFs
IGxlbmd0aCBmb3IgdGhlIGZpcm13YXJlIG1vZHVsZXMgd2l0aCBhIHJlYXNvbmFibGUgbGFyZ2UK
PiA+ID4gLSAgICAgKiBhbGlnbm1lbnQgc2l6ZSB0byBhbGlnbiBlYWNoIHRoZSBtb2R1bGVzLgo+
ID4gPiAtICAgICAqLwo+ID4gPiAtICAgIHRvdGFsX2xlbiA9IE1LQUxJR04oZG9tLT5hY3BpX21v
ZHVsZS5sZW5ndGgsIE1PRFVMRV9BTElHTik7Cj4gPiA+IC0gICAgb2Zmc2V0MSA9IHRvdGFsX2xl
bjsKPiA+ID4gLSAgICB0b3RhbF9sZW4gKz0gTUtBTElHTihkb20tPnNtYmlvc19tb2R1bGUubGVu
Z3RoLCBNT0RVTEVfQUxJR04pOwo+ID4gPiAtCj4gPiA+IC0gICAgLyogV2FudCB0byBwbGFjZSB0
aGUgbW9kdWxlcyAxTWIrY2hhbmdlIGJlaGluZCB0aGUgbG9hZGVyIGltYWdlLiAqLwo+ID4gPiAt
ICAgICptc3RhcnRfb3V0ID0gTUtBTElHTihlbGYtPnBlbmQsIE1CX0FMSUdOKSArIChNQl9BTElH
Tik7Cj4gPiA+IC0gICAgKm1lbmRfb3V0ID0gKm1zdGFydF9vdXQgKyB0b3RhbF9sZW47Cj4gPiA+
IC0KPiA+ID4gLSAgICBpZiAoICptZW5kX291dCA+IHZlbmQgKQo+ID4gPiAtICAgICAgICByZXR1
cm4gLTE7Cj4gPiA+IC0KPiA+ID4gLSAgICBpZiAoIGRvbS0+YWNwaV9tb2R1bGUubGVuZ3RoICE9
IDAgKQo+ID4gPiAtICAgICAgICBkb20tPmFjcGlfbW9kdWxlLmd1ZXN0X2FkZHJfb3V0ID0gKm1z
dGFydF9vdXQ7Cj4gPiA+IC0gICAgaWYgKCBkb20tPnNtYmlvc19tb2R1bGUubGVuZ3RoICE9IDAg
KQo+ID4gPiAtICAgICAgICBkb20tPnNtYmlvc19tb2R1bGUuZ3Vlc3RfYWRkcl9vdXQgPSAqbXN0
YXJ0X291dCArIG9mZnNldDE7Cj4gPiA+ICsgICAgaWYgKCBtb2R1bGUtPmxlbmd0aCApCj4gPiA+
ICsgICAgewo+ID4gPiArICAgICAgICBpZiAoIHhjX2RvbV9hbGxvY19zZWdtZW50KGRvbSwgJnNl
ZywgbmFtZSwgMCwgbW9kdWxlLT5sZW5ndGgpICkKPiA+ID4gKyAgICAgICAgICAgIGdvdG8gZXJy
Owo+ID4gPiArICAgICAgICBkZXN0ID0geGNfZG9tX3NlZ190b19wdHIoZG9tLCAmc2VnKTsKPiA+
ID4gKyAgICAgICAgaWYgKCBkZXN0ID09IE5VTEwgKQo+ID4gPiArICAgICAgICB7Cj4gPiA+ICsg
ICAgICAgICAgICBET01QUklOVEYoIiVzOiB4Y19kb21fc2VnX3RvX3B0cihkb20sICZzZWcpID0+
IE5VTEwiLAo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgIF9fRlVOQ1RJT05fXyk7Cj4gPiA+
ICsgICAgICAgICAgICBnb3RvIGVycjsKPiA+ID4gKyAgICAgICAgfQo+ID4gPiArICAgICAgICBt
ZW1jcHkoZGVzdCwgbW9kdWxlLT5kYXRhLCBtb2R1bGUtPmxlbmd0aCk7Cj4gPiA+ICsgICAgICAg
IG1vZHVsZS0+Z3Vlc3RfYWRkcl9vdXQgPSBzZWcudnN0YXJ0Owo+ID4gPiArICAgICAgICBpZiAo
IG1vZHVsZS0+Z3Vlc3RfYWRkcl9vdXQgPiBVSU5UMzJfTUFYIHx8Cj4gPiA+ICsgICAgICAgICAg
ICAgbW9kdWxlLT5ndWVzdF9hZGRyX291dCArIG1vZHVsZS0+bGVuZ3RoID4gVUlOVDMyX01BWCAp
Cj4gPiA+ICsgICAgICAgIHsKPiA+ID4gKyAgICAgICAgICAgIERPTVBSSU5URigiJXM6IE1vZHVs
ZSAlcyB3b3VsZCBiZSBsb2FkZWQgYWJyb3ZlIDRHQiIsCj4gPiA+ICsgICAgICAgICAgICAgICAg
ICAgICAgX19GVU5DVElPTl9fLCBuYW1lKTsKPiA+ID4gKyAgICAgICAgICAgIGdvdG8gZXJyOwo+
ID4gPiArICAgICAgICB9Cj4gPiAKPiA+IE9uZSBxdWVzdGlvbjoKPiA+IAo+ID4gQ2FuIHRoaXMg
Y2hlY2sgYWxzbyBhY2NvdW50IGZvciBNTUlPIGhvbGUgYmVsb3cgNEc/IE1heWJlIHVzZQo+ID4g
ZG9tLT5tbWlvX3NpemU/Cj4gCj4gWWVzLCBJIGd1ZXNzIEkgY2FuIGNoZWNrIGFnYWluc3QgZG9t
LT5tbWlvX3N0YXJ0LiBTaG91bGQgSSBhbHNvIGNoZWNrCj4gdGhhdCBtbWlvX3N0YXJ0IGhhdmUg
cmVhc29uYWJsZSB2YWx1ZT8gKDw0RywgYW5kIG5vdCAweDApIE9yIGlzCj4gbW1pb19zdGFydCBp
cyBhbHJlYWR5IHN1cHBvc2VkIHRvIGhhdmUgYSBnb29kIHZhbHVlPwo+IAoKbW1pb19zdGFydCBz
aG91bGQgYWxyZWFkeSBoYXZlIGEgc2FuZSB2YWx1ZSBoZXJlIC0tIG9yIGF0IGxlYXN0IEkgaG9w
ZQpzby4gVGhlIHNhbml0eSBvZiBtbWlvX3N0YXJ0IHNob3VsZCBiZSBjaGVja2VkIHdoZXJlIGl0
IGlzIGFzc2lnbmVkLgoKV2VpLgoKPiA+IE90aGVyIHRoYW4gdGhpcywgdGhpcyBwYXRjaCBsb29r
cyBnb29kLgo+IAo+IFRoYW5rcywKPiAKPiAtLSAKPiBBbnRob255IFBFUkFSRAoKX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcg
bGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRl
dmVsCg==