From: Wei Liu <wei.liu2@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH v3 4/5] libxl: update vcpus bitmap in retrieved guest config
Date: Mon, 11 Jul 2016 15:59:52 +0100 [thread overview]
Message-ID: <20160711145952.GD13434@citrix.com> (raw)
In-Reply-To: <20160711113143.GG7019@citrix.com>
On Mon, Jul 11, 2016 at 12:31:43PM +0100, Wei Liu wrote:
[...]
>
> >
> > > + /* If the user did not explicitly specify a device model
> > > + * version, we need to use the same logic used during domain
> > > + * creation to derive the device model version.
> > > + */
> > > + version = d_config->b_info.device_model_version;
> > > + if (version == LIBXL_DEVICE_MODEL_VERSION_UNKNOWN)
> > > + version = libxl__get_device_model_version(gc, &d_config->b_info);
> >
> > I think this is rather unfortunate. Won't changing the default device
> > model while the domain is running will cause this function to give
> > wrong answers ?
>
> I think saving the device model into the template should work. No need
> to derive it during runtime.
>
Actually this information is already available via
libxl__device_model_version_running.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-11 14:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 9:31 [PATCH v3 0/5] libxl: libxl: update available vcpus map in retrieve configuration function Wei Liu
2016-06-15 9:31 ` [PATCH v3 1/5] libxl: libxl_domain_need_memory shouldn't modify b_info Wei Liu
2016-06-15 13:31 ` Dario Faggioli
2016-06-15 13:38 ` Wei Liu
2016-07-08 17:35 ` Ian Jackson
2016-07-11 11:03 ` Wei Liu
2016-06-15 9:31 ` [PATCH v3 2/5] libxl: factor out libxl__get_device_modlel_version Wei Liu
2016-06-15 13:27 ` Dario Faggioli
2016-06-15 17:04 ` Anthony PERARD
2016-07-08 17:37 ` Ian Jackson
2016-06-15 9:31 ` [PATCH v3 3/5] libxl: introduce libxl__qmp_query_cpus Wei Liu
2016-06-15 13:26 ` Dario Faggioli
2016-06-15 16:48 ` Anthony PERARD
2016-07-08 17:45 ` Ian Jackson
2016-06-15 9:31 ` [PATCH v3 4/5] libxl: update vcpus bitmap in retrieved guest config Wei Liu
2016-06-15 17:20 ` Anthony PERARD
2016-07-08 17:44 ` Ian Jackson
2016-07-11 11:31 ` Wei Liu
2016-07-11 14:59 ` Wei Liu [this message]
2016-06-15 9:31 ` [PATCH v3 5/5] libxl: only issue cpu-add call to QEMU for not present CPU Wei Liu
2016-07-08 17:48 ` Ian Jackson
2016-07-11 11:32 ` Wei Liu
2016-07-02 10:22 ` [PATCH v3 0/5] libxl: libxl: update available vcpus map in retrieve configuration function Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160711145952.GD13434@citrix.com \
--to=wei.liu2@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).