From: Anthony PERARD <anthony.perard@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org, Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH v6 06/14] xen: Move the hvm_start_info C representation from libxc to public/xen.h
Date: Tue, 12 Jul 2016 16:36:22 +0100 [thread overview]
Message-ID: <20160712153622.GI1729@perard.uk.xensource.com> (raw)
In-Reply-To: <30e9f2b9-9249-9657-265d-c53632b2e58c@citrix.com>
On Tue, Jul 12, 2016 at 04:09:59PM +0100, Andrew Cooper wrote:
> On 12/07/16 15:42, Anthony PERARD wrote:
> > +#ifndef __XEN_PUBLIC_ARCH_X86_HVM_START_INFO_H__
> > +#define __XEN_PUBLIC_ARCH_X86_HVM_START_INFO_H__
> > +
> > +/*
> > + * C representation of the x86/HVM start info layout.
> > + *
> > + * The canonical definition of this layout resides in public/xen.h, this
>
> You should also move the big comment block from public/xen.h to here,
> along with the XEN_HVM_START_MAGIC_VALUE define.
Is it fine to move the comment and the define even if there has been one
release of Xen with this in xen.h?
> There is no point having it split across two locations in the public
> headers.
--
Anthony PERARD
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-12 15:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 14:42 [PATCH v6 00/14] Load BIOS via toolstack instead of been embedded in hvmloader Anthony PERARD
2016-07-12 14:42 ` [PATCH v6 01/14] libxc: Rework extra module initialisation Anthony PERARD
2016-07-12 15:01 ` Wei Liu
2016-07-12 14:42 ` [PATCH v6 02/14] libxc: Prepare a start info structure for hvmloader Anthony PERARD
2016-07-12 15:01 ` Wei Liu
2016-07-12 14:42 ` [PATCH v6 03/14] configure: #define SEABIOS_PATH and OVMF_PATH Anthony PERARD
2016-07-12 14:42 ` [PATCH v6 04/14] firmware/makefile: install BIOS blob Anthony PERARD
2016-07-12 14:42 ` [PATCH v6 05/14] libxl: Load guest BIOS from file Anthony PERARD
2016-07-12 15:01 ` Wei Liu
2016-07-12 14:42 ` [PATCH v6 06/14] xen: Move the hvm_start_info C representation from libxc to public/xen.h Anthony PERARD
2016-07-12 14:57 ` Wei Liu
2016-07-12 15:09 ` Andrew Cooper
2016-07-12 15:36 ` Anthony PERARD [this message]
2016-07-12 16:07 ` Andrew Cooper
2016-07-14 15:55 ` Anthony PERARD
2016-07-12 14:42 ` [PATCH v6 07/14] hvmloader: Grab the hvm_start_info pointer Anthony PERARD
2016-07-12 14:42 ` [PATCH v6 08/14] hvmloader: Locate the BIOS blob Anthony PERARD
2016-07-12 14:42 ` [PATCH v6 09/14] hvmloader: Check modules whereabouts in perform_tests Anthony PERARD
2016-07-12 14:42 ` [PATCH v6 10/14] hvmloader: Load SeaBIOS from hvm_start_info modules Anthony PERARD
2016-07-12 14:42 ` [PATCH v6 11/14] hvmloader: Load OVMF from modules Anthony PERARD
2016-07-12 14:42 ` [PATCH v6 12/14] hvmloader: bios->bios_load() now needs to be defined Anthony PERARD
2016-07-12 14:42 ` [PATCH v6 13/14] hvmloader: Always build-in SeaBIOS and OVMF loader Anthony PERARD
2016-07-12 14:42 ` [PATCH v6 14/14] configure: do not depend on SEABIOS_PATH or OVMF_PATH Anthony PERARD
2016-07-12 15:03 ` [PATCH v6 00/14] Load BIOS via toolstack instead of been embedded in hvmloader Wei Liu
2016-07-12 15:04 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160712153622.GI1729@perard.uk.xensource.com \
--to=anthony.perard@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).