xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ross Lagerwall <ross.lagerwall@citrix.com>
Cc: xen-devel@lists.xen.org
Subject: Re: [PATCH LIVEPATCH-BUILD-TOOLS 1/2] Fix getopt parsing of long options
Date: Thu, 21 Jul 2016 10:33:40 -0400	[thread overview]
Message-ID: <20160721143340.GF12549@char.us.oracle.com> (raw)
In-Reply-To: <1469026184-15320-1-git-send-email-ross.lagerwall@citrix.com>

On Wed, Jul 20, 2016 at 03:49:43PM +0100, Ross Lagerwall wrote:

What happend to your SoB?

The patch is fine otherwise.
> ---
>  livepatch-build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/livepatch-build b/livepatch-build
> index 7395b49..d9d9da3 100755
> --- a/livepatch-build
> +++ b/livepatch-build
> @@ -185,7 +185,7 @@ usage() {
>  
>  find_tools || die "can't find supporting tools"
>  
> -options=$(getopt -o hs:p:c:o:j:k:d -l "help,srcdir:patch:config:output:cpus:,skip:,debug,xen-debug,xen-syms:,depends:,prelink" -- "$@") || die "getopt failed"
> +options=$(getopt -o hs:p:c:o:j:k:d -l "help,srcdir:,patch:,config:,output:,cpus:,skip:,debug,xen-debug,xen-syms:,depends:,prelink" -- "$@") || die "getopt failed"
>  
>  eval set -- "$options"
>  
> -- 
> 2.7.4
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

      parent reply	other threads:[~2016-07-21 14:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-20 14:49 [PATCH LIVEPATCH-BUILD-TOOLS 1/2] Fix getopt parsing of long options Ross Lagerwall
2016-07-20 14:49 ` [PATCH LIVEPATCH-BUILD-TOOLS 2/2] Prevent spurious rebuilding Ross Lagerwall
2016-07-21 14:33   ` Konrad Rzeszutek Wilk
2016-07-21 14:48     ` Ross Lagerwall
2016-07-21 15:20       ` Konrad Rzeszutek Wilk
2016-07-21 14:33 ` Konrad Rzeszutek Wilk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160721143340.GF12549@char.us.oracle.com \
    --to=konrad.wilk@oracle.com \
    --cc=ross.lagerwall@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).