From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Julien Grall <julien.grall@arm.com>
Cc: sstabellini@kernel.org, xen-devel@lists.xen.org
Subject: Re: [PATCH v5 2/7] xen/arm: cpufeature: Provide an helper to check if a capability is supported
Date: Fri, 22 Jul 2016 11:39:09 -0400 [thread overview]
Message-ID: <20160722153909.GC27628@char.us.oracle.com> (raw)
In-Reply-To: <2eb2cd12-8faa-4ebe-dee2-314cbc32a579@arm.com>
On Fri, Jul 22, 2016 at 04:31:13PM +0100, Julien Grall wrote:
> Hi Konrad,
>
> On 22/07/16 15:18, Konrad Rzeszutek Wilk wrote:
> >On Wed, Jul 20, 2016 at 04:25:55PM +0100, Julien Grall wrote:
> >>diff --git a/xen/arch/arm/cpufeature.c b/xen/arch/arm/cpufeature.c
> >>index 7a1b56b..088625b 100644
> >>--- a/xen/arch/arm/cpufeature.c
> >>+++ b/xen/arch/arm/cpufeature.c
> >>@@ -24,6 +24,22 @@
> >>
> >> DECLARE_BITMAP(cpu_hwcaps, ARM_NCAPS);
> >>
> >>+void update_cpu_capabilities(const struct arm_cpu_capabilities *caps,
> >>+ const char *info)
> >>+{
> >>+ int i;
> >>+
> >>+ for ( i = 0; caps[i].matches; i++ )
> >>+ {
> >>+ if ( !caps[i].matches(&caps[i]) )
> >
> >So what if the 'struct arm_cpu_capabilitues' has '->matches' set to
> >NULL?
>
> It is the exit condition of the loop:
>
> for ( i = 0; caps[i].matches; i++ )
Duh!
Ignore my query then please.
>
> Regards,
>
> --
> Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-22 15:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 15:25 [PATCH v5 0/7] xen/arm: Introduce alternative runtime patching for ARM64 Julien Grall
2016-07-20 15:25 ` [PATCH v5 1/7] xen/arm: Introduce alternative runtime patching Julien Grall
2016-07-21 0:32 ` [PATCH v5 1/7] xen/arm: Introduce alternative runtime patchingo Stefano Stabellini
2016-07-22 14:15 ` [PATCH v5 1/7] xen/arm: Introduce alternative runtime patching Konrad Rzeszutek Wilk
2016-07-22 15:29 ` Julien Grall
2016-07-22 15:38 ` Konrad Rzeszutek Wilk
2016-07-22 15:47 ` Julien Grall
2016-07-20 15:25 ` [PATCH v5 2/7] xen/arm: cpufeature: Provide an helper to check if a capability is supported Julien Grall
2016-07-22 14:18 ` Konrad Rzeszutek Wilk
2016-07-22 15:31 ` Julien Grall
2016-07-22 15:39 ` Konrad Rzeszutek Wilk [this message]
2016-07-20 15:25 ` [PATCH v5 3/7] xen/arm: Detect silicon revision and set cap bits accordingly Julien Grall
2016-07-22 14:24 ` Konrad Rzeszutek Wilk
2016-07-27 16:09 ` Julien Grall
2016-07-20 15:25 ` [PATCH v5 4/7] xen/arm: Document the errata implemented in Xen Julien Grall
2016-07-22 14:25 ` Konrad Rzeszutek Wilk
2016-07-20 15:25 ` [PATCH v5 5/7] xen/arm: arm64: Add Cortex-A53 cache errata workaround Julien Grall
2016-07-20 15:25 ` [PATCH v5 6/7] xen/arm: arm64: Add cortex-A57 erratum 832075 workaround Julien Grall
2016-07-20 15:26 ` [PATCH v5 7/7] xen/arm: traps: Don't inject a fault if the translation VA -> IPA fails Julien Grall
2016-07-22 14:29 ` [PATCH v5 0/7] xen/arm: Introduce alternative runtime patching for ARM64 Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160722153909.GC27628@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).