From: Wei Liu <wei.liu2@citrix.com>
To: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Rusty Bird <rustybird@openmailbox.org>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH 1/2] systemd: use standard dependencies for xendriverdomain.service
Date: Mon, 25 Jul 2016 10:17:44 +0100 [thread overview]
Message-ID: <20160725091744.GA1008@citrix.com> (raw)
In-Reply-To: <20160724192657.GA22529@mail-itl>
On Sun, Jul 24, 2016 at 09:26:57PM +0200, Marek Marczykowski-Górecki wrote:
> Having DefaultDependencies=no means it can be started before / is
> remounted read-write, which will result in various failures (to start
> with opening the log).
> Since "libxl: trigger attach events for devices attached before xl devd
> startup" it is no longer important to start it as early as possible,
> because it will process devices created before its startup.
>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
The reasoning makes sense.
Acked-by: Wei Liu <wei.liu2@citrix.com>
Also CC Rusty (author of this file)
> ---
> tools/hotplug/Linux/systemd/xendriverdomain.service.in | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/hotplug/Linux/systemd/xendriverdomain.service.in b/tools/hotplug/Linux/systemd/xendriverdomain.service.in
> index c0cd454..0afb54d 100644
> --- a/tools/hotplug/Linux/systemd/xendriverdomain.service.in
> +++ b/tools/hotplug/Linux/systemd/xendriverdomain.service.in
> @@ -1,6 +1,5 @@
> [Unit]
> Description=Xen driver domain device daemon
> -DefaultDependencies=no
> Requires=proc-xen.mount
> After=proc-xen.mount
> ConditionVirtualization=xen
> --
> 2.5.5
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-25 9:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-24 19:26 [PATCH 1/2] systemd: use standard dependencies for xendriverdomain.service Marek Marczykowski-Górecki
2016-07-25 9:17 ` Wei Liu [this message]
2016-07-25 13:22 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160725091744.GA1008@citrix.com \
--to=wei.liu2@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=marmarek@invisiblethingslab.com \
--cc=rustybird@openmailbox.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).