From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Subject: Re: [PATCH 2/2] systemd: drop dependency on proc-xen.mount in xendriverdomain.service Date: Mon, 25 Jul 2016 11:30:32 +0200 Message-ID: <20160725093032.GO5036@mail-itl> References: <1469388272-22789-1-git-send-email-marmarek@invisiblethingslab.com> <20160724192713.GB22529@mail-itl> <20160725092746.GB1008@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0845874310169267242==" Return-path: In-Reply-To: <20160725092746.GB1008@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Wei Liu Cc: Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org --===============0845874310169267242== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sU4rRG038CsJurvk" Content-Disposition: inline --sU4rRG038CsJurvk Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 25, 2016 at 10:27:47AM +0100, Wei Liu wrote: > On Sun, Jul 24, 2016 at 09:27:13PM +0200, Marek Marczykowski-G=C3=B3recki= wrote: > > It is no longer required since xl devd use /dev/xen interface. > >=20 >=20 > How would this unit work when there is no /dev/xen interface? Does it happen in reality? I thought /proc/xen is deprecated for a long time... > To be precise, we prefer /dev/xen interfaces whenever possible but there > is a fallback to /proc/xen. Note that a lot of other unit files have > this dependency on proc-xen.mount. >=20 > I'm inclined to say we should keep this dependency but I'm not sure if I > missed some obvious things. >=20 > > Cc: Ian Jackson > > Cc: Wei Liu > > Signed-off-by: Marek Marczykowski-G=C3=B3recki > > --- > > tools/hotplug/Linux/systemd/xendriverdomain.service.in | 2 -- > > 1 file changed, 2 deletions(-) > >=20 > > diff --git a/tools/hotplug/Linux/systemd/xendriverdomain.service.in b/t= ools/hotplug/Linux/systemd/xendriverdomain.service.in > > index 0afb54d..a100309 100644 > > --- a/tools/hotplug/Linux/systemd/xendriverdomain.service.in > > +++ b/tools/hotplug/Linux/systemd/xendriverdomain.service.in > > @@ -1,7 +1,5 @@ > > [Unit] > > Description=3DXen driver domain device daemon > > -Requires=3Dproc-xen.mount > > -After=3Dproc-xen.mount > > ConditionVirtualization=3Dxen > > =20 > > [Service] > > --=20 > > 2.5.5 >=20 >=20 --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? --sU4rRG038CsJurvk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXldw8AAoJENuP0xzK19csBB4H/0zBm34ubtmx1GhSK8Cv/huR IyiCtb0s+4Nxida9gBXoD3Hjb3/reQv3HOXauCvOuImLZFhvDA0qTXMo53d3fUVN q7SY1kiMtYhpAJIy69KZCA5Z3cgRPcoEPq9jNhtlmomn1ZdXHpOTHpaWX7LSogLg 09qJnkSLS6sSfrSj3lQPQuUJqwxowPv/ORSVi1E9cB8hb6JrSy4Jl2qRND5BS7W5 70U+f9B+Nq1ZYh6DfWAjR08IKtLGwU2V5Sdmb4kvHwy6AqCzN5tXkF4r1JCSX7eX /4yobfQ1qwGfE+uGDUbHo3mPJWvrb6unt0qrw70yOgRm6JM8O6X5j2bM9pFZ/UU= =zNEu -----END PGP SIGNATURE----- --sU4rRG038CsJurvk-- --===============0845874310169267242== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============0845874310169267242==--