From: Wei Liu <wei.liu2@citrix.com>
To: Juergen Gross <jgross@suse.com>
Cc: wei.liu2@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH 1/6] libxl: add "merge" function to generic device type support
Date: Mon, 25 Jul 2016 11:45:58 +0100 [thread overview]
Message-ID: <20160725104558.GL1008@citrix.com> (raw)
In-Reply-To: <1468337444-24108-2-git-send-email-jgross@suse.com>
On Tue, Jul 12, 2016 at 05:30:39PM +0200, Juergen Gross wrote:
> Instead of using a macro generating the code to merge xenstore and
> json configuration data, use the generic device type support for
> this purpose.
>
> This requires to add some accessor functions to the framework and
> a structure for disks (as disks are added separately they didn't need
> such a structure up to now).
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
I definitely think this is a good idea.
The code looks good to me:
Acked-by: Wei Liu <wei.liu2@citrix.com>
I didn't do a line-by-line review though because most code looks very
mechanical. I'm confident that we can sort out issues should they arise.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-25 10:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 15:30 [PATCH 0/6] libxl: extend device type framework Juergen Gross
2016-07-12 15:30 ` [PATCH 1/6] libxl: add "merge" function to generic device type support Juergen Gross
2016-07-25 10:45 ` Wei Liu [this message]
2017-01-19 16:14 ` Olaf Hering
2017-01-19 16:19 ` Wei Liu
2017-01-19 16:51 ` Juergen Gross
2016-07-12 15:30 ` [PATCH 2/6] libxl: add "pv device mode needed" support to device type framework Juergen Gross
2016-07-25 10:46 ` Wei Liu
2016-07-12 15:30 ` [PATCH 3/6] libxl: move library pvusb specific code into libxl_pvusb.c Juergen Gross
2016-07-25 10:46 ` Wei Liu
2016-07-12 15:30 ` [PATCH 4/6] libxl: split libxl vtpm code into one source Juergen Gross
2016-07-25 10:46 ` Wei Liu
2016-07-12 15:30 ` [PATCH 5/6] libxl: add config update callback to device type framework Juergen Gross
2016-07-25 10:46 ` Wei Liu
2016-07-12 15:30 ` [PATCH 6/6] libxl: move common nic stuff into one source Juergen Gross
2016-07-25 10:46 ` Wei Liu
2016-07-21 13:12 ` [PATCH 0/6] libxl: extend device type framework Juergen Gross
2016-07-27 11:45 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160725104558.GL1008@citrix.com \
--to=wei.liu2@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).