From: Wei Liu <wei.liu2@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>,
Rusty Bird <rustybird@openmailbox.org>
Subject: Re: [PATCH] systemd: remove hard-coded pid file in xendriverdomain service
Date: Tue, 2 Aug 2016 14:58:57 +0100 [thread overview]
Message-ID: <20160802135857.GN22419@citrix.com> (raw)
In-Reply-To: <22432.41766.339499.332151@mariner.uk.xensource.com>
On Tue, Aug 02, 2016 at 02:41:58PM +0100, Ian Jackson wrote:
> Wei Liu writes ("[PATCH] systemd: remove hard-coded pid file in xendriverdomain service"):
> > Per the discussion in [0], the hard-coded pid file can be removed
> > completely. Systemd has no trouble figuring out the pid of devd all by
> > itself.
> >
> > [0]: https://lists.xen.org/archives/html/xen-devel/2016-07/msg01393.html
>
> I'm not qualified to have much of an opinion this but I'm happy to see
> it go in based on what I assume is a test report from Rusty Bird ?
>
No, it's not a test report.
Rusty Bird was the submitter of that xl devd unit file. I assumed he had
experience of setting up xl devd without a pid file under systemd and
did what he asked for.
> On that basis,
>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
>
> Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-08-02 13:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 15:36 [PATCH] systemd: remove hard-coded pid file in xendriverdomain service Wei Liu
2016-08-02 13:41 ` Ian Jackson
2016-08-02 13:58 ` Wei Liu [this message]
2016-08-02 17:39 ` Rusty Bird
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160802135857.GN22419@citrix.com \
--to=wei.liu2@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=rustybird@openmailbox.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).