From: Wei Liu <wei.liu2@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>
Subject: Re: [OSSTEST PATCH RFC 06/14] Introduce ts-xtf-build
Date: Thu, 4 Aug 2016 12:57:02 +0100 [thread overview]
Message-ID: <20160804115702.GE32096@citrix.com> (raw)
In-Reply-To: <22435.11386.847362.920376@mariner.uk.xensource.com>
On Thu, Aug 04, 2016 at 12:52:26PM +0100, Ian Jackson wrote:
> Wei Liu writes ("[OSSTEST PATCH RFC 06/14] Introduce ts-xtf-build"):
> > Clone, build and package XTF for later use.
> ...
> > diff --git a/ts-xtf-build b/ts-xtf-build
> > new file mode 100755
> > index 0000000..5c4c3ec
> > --- /dev/null
> > +++ b/ts-xtf-build
> ...
> > +selectbuildhost(\@ARGV);
> > +# remaining arguments are passed as targets to "make"
>
> This doesn't seem to be actually true.
>
Right, I will delete this.
> > + target_cmd_build($ho, 300, $builddir, <<END);
> > + cd xtf
> > + rm -f ../xtf-build-ok-stamp
> > + ( make xtfdir=$xtfdir 2>&1 && touch ../xtf-build-ok-stamp
> > + ) |tee ../xtf-build-log
> > + test -f ../xtf-build-ok-stamp
>
> I think you should lift buildcmd_stamped_logged out of ts-xen-build.
>
NP.
> > +#/;
>
> These are for the benefit of some editor's indenting ?
>
Yes. I think so. Copied and pasted from ts-xen-build, actually.
> > +sub stash () {
> > + built_stash($ho, $builddir, "xtfdist", "xtfdist");
> > +}
>
> Can you post a tar zvvtf of a sample xtfdist tarball ?
drwxr-xr-x osstest/osstest 0 2016-08-04 08:30 home/
drwxr-xr-x osstest/osstest 0 2016-08-04 08:30 home/osstest/
drwxr-xr-x osstest/osstest 0 2016-08-04 08:30 home/osstest/build.66916.build-amd64-xtf/
drwxr-xr-x osstest/osstest 0 2016-08-04 08:30 home/osstest/build.66916.build-amd64-xtf/xtf/
-rwxr-xr-x osstest/osstest 20124 2016-08-04 08:30 home/osstest/build.66916.build-amd64-xtf/xtf/xtf-runner
drwxr-xr-x osstest/osstest 0 2016-08-04 08:30 home/osstest/build.66916.build-amd64-xtf/xtf/tests/
drwxr-xr-x osstest/osstest 0 2016-08-04 08:30 home/osstest/build.66916.build-amd64-xtf/xtf/tests/xsa-168/
-rwxr-xr-x osstest/osstest 1179952 2016-08-04 08:30 home/osstest/build.66916.build-amd64-xtf/xtf/tests/xsa-168/test-hvm64-xsa-168
-rw-r--r-- osstest/osstest 563 2016-08-04 08:30 home/osstest/build.66916.build-amd64-xtf/xtf/tests/xsa-168/test-hvm64-xsa-168.cfg
-rw-r--r-- osstest/osstest 116 2016-08-04 08:30 home/osstest/build.66916.build-amd64-xtf/xtf/tests/xsa-168/info.json
drwxr-xr-x osstest/osstest 0 2016-08-04 08:30 home/osstest/build.66916.build-amd64-xtf/xtf/tests/xsa-173/
-rw-r--r-- osstest/osstest 528 2016-08-04 08:30 home/osstest/build.66916.build-amd64-xtf/xtf/tests/xsa-173/test-hvm64-xsa-173.cfg
[repetitive output truncated]
>
> Thanks,
> Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-08-04 11:57 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 8:45 [OSSTEST PATCH RFC 00/14] Integrate XTF into OSSTest Wei Liu
2016-08-04 8:45 ` [OSSTEST PATCH RFC 01/14] ts-xen-build: always compile in FEP support Wei Liu
2016-08-04 11:46 ` Ian Jackson
2016-08-04 11:49 ` Wei Liu
2016-08-04 11:53 ` Andrew Cooper
2016-08-04 12:03 ` Wei Liu
2016-08-04 13:28 ` Andrew Cooper
2016-08-04 14:03 ` Wei Liu
2016-08-04 14:08 ` Andrew Cooper
2016-08-04 15:22 ` Ian Jackson
2016-08-04 15:26 ` Wei Liu
2016-08-04 15:36 ` Ian Jackson
2016-08-04 8:45 ` [OSSTEST PATCH RFC 02/14] TestSupport: factor out target_jobdir_subdir Wei Liu
2016-08-04 11:47 ` Ian Jackson
2016-08-04 8:45 ` [OSSTEST PATCH RFC 03/14] DO NOT APPLY ts-leak-check: sleep 5 seconds before collecting stuff Wei Liu
2016-08-04 8:45 ` [OSSTEST PATCH RFC 04/14] ap-common: add xtf tree Wei Liu
2016-08-04 11:49 ` Ian Jackson
2016-08-04 13:34 ` Andrew Cooper
2016-08-04 15:21 ` Ian Jackson
2016-08-04 15:43 ` Andrew Cooper
2016-08-04 16:13 ` Ian Jackson
2016-08-04 18:20 ` Andrew Cooper
2016-08-04 14:06 ` Wei Liu
2016-08-04 8:45 ` [OSSTEST PATCH RFC 05/14] DO NOT APPLY point xtf to my personal tree Wei Liu
2016-08-04 8:45 ` [OSSTEST PATCH RFC 06/14] Introduce ts-xtf-build Wei Liu
2016-08-04 11:52 ` Ian Jackson
2016-08-04 11:57 ` Wei Liu [this message]
2016-08-04 15:04 ` Ian Jackson
2016-08-04 15:17 ` [OSSTEST PATCH RFC 06/14] Introduce ts-xtf-build [and 1 more messages] Ian Jackson
2016-08-04 15:35 ` Wei Liu
2016-08-04 16:05 ` Ian Jackson
2016-08-04 18:10 ` Andrew Cooper
2016-08-04 18:12 ` Ian Jackson
2016-08-04 8:45 ` [OSSTEST PATCH RFC 07/14] sg-run-job: create xtf build recipe Wei Liu
2016-08-04 11:53 ` Ian Jackson
2016-08-04 8:45 ` [OSSTEST PATCH RFC 08/14] Introduce ts-xtf-install Wei Liu
2016-08-04 11:54 ` Ian Jackson
2016-08-04 11:58 ` Wei Liu
2016-08-04 8:45 ` [OSSTEST PATCH RFC 09/14] mfi-common: create xtf build job for 4.8 onwards Wei Liu
2016-08-04 11:59 ` Ian Jackson
2016-08-04 14:12 ` Wei Liu
2016-08-04 8:45 ` [OSSTEST PATCH RFC 10/14] Introduce ts-xtf-fep Wei Liu
2016-08-04 12:00 ` Ian Jackson
2016-08-04 12:03 ` Wei Liu
2016-08-04 8:45 ` [OSSTEST PATCH RFC 11/14] Introduce ts-xtf-run Wei Liu
2016-08-04 12:19 ` Ian Jackson
2016-08-04 14:40 ` Wei Liu
2016-08-04 15:31 ` Ian Jackson
2016-08-04 8:45 ` [OSSTEST PATCH RFC 12/14] sg-run-job: test-xtf recipe Wei Liu
2016-08-04 12:20 ` Ian Jackson
2016-08-04 8:45 ` [OSSTEST PATCH RFC 13/14] make-flight: create 5 xtf jobs Wei Liu
2016-08-04 12:24 ` Ian Jackson
2016-08-04 8:46 ` [OSSTEST PATCH RFC 14/14] Create XTF branch Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160804115702.GE32096@citrix.com \
--to=wei.liu2@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).