From: Wei Liu <wei.liu2@citrix.com>
To: George Dunlap <george.dunlap@citrix.com>
Cc: xen-devel@lists.xenproject.org,
Dario Faggioli <dario.faggioli@citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Anshul Makkar <anshul.makkar@citrix.com>,
Ian Jackson <ian.jackson@citrix.com>
Subject: Re: [PATCH 4/4] tools/xenalyze: Allow automatic resizing of sample buffers
Date: Mon, 8 Aug 2016 12:09:46 +0100 [thread overview]
Message-ID: <20160808110946.GG32096@citrix.com> (raw)
In-Reply-To: <20160808110558.GA32096@citrix.com>
On Mon, Aug 08, 2016 at 12:05:58PM +0100, Wei Liu wrote:
> On Mon, Aug 08, 2016 at 10:54:31AM +0100, George Dunlap wrote:
> > +
> > + new_size = s->sample_size << 1;
> > +
> > + if (new_size == 0)
> > + new_size = opt.sample_size;
> > +
> > + if (opt.sample_max != 0 && new_size > opt.sample_max)
> > + new_size = opt.sample_max;
> > +
> > + //printf("New size: %d\n", new_size);
>
> Maybe this needs to be deleted?
>
FAOD I don't think it is worthy of resending just because of this
cosmetic change. Whatever adjustment can be done while committing.
Acked-by: Wei Liu <wei.liu2@citrix.com>
> Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-08-08 11:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 9:54 [PATCH 1/4] tools/xenalyze: Remove bogus library dependencies George Dunlap
2016-08-08 9:54 ` [PATCH 2/4] tools/xenalyze: Remove weighted cpi summaries George Dunlap
2016-08-08 11:06 ` Wei Liu
2016-08-08 9:54 ` [PATCH 3/4] tools/xenalyze: Get rid of extraneous data structure George Dunlap
2016-08-08 11:06 ` Wei Liu
2016-08-08 9:54 ` [PATCH 4/4] tools/xenalyze: Allow automatic resizing of sample buffers George Dunlap
2016-08-08 11:05 ` Wei Liu
2016-08-08 11:09 ` Wei Liu [this message]
2016-08-09 14:48 ` George Dunlap
2016-08-08 17:11 ` anshul makkar
2016-08-09 10:01 ` George Dunlap
2016-08-08 11:06 ` [PATCH 1/4] tools/xenalyze: Remove bogus library dependencies Wei Liu
2016-08-08 12:25 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160808110946.GG32096@citrix.com \
--to=wei.liu2@citrix.com \
--cc=anshul.makkar@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).