Re: [OSSTEST PATCH RFC v2 11/14] Introduce ts-xtf-run

[Wei Liu <wei.liu2@citrix.com>]

On Mon, Aug 08, 2016 at 03:55:15PM +0100, Ian Jackson wrote:
> Wei Liu writes ("[OSSTEST PATCH RFC v2 11/14] Introduce ts-xtf-run"):
> > This is the main script for running XTF.  It will first perform
> > selftest, and then run each XTF test case as a substep.
> ...
> > +# XTF results (runner returned numeric values) and OSStest results:
> > +#
> > +# SUCCESS(0)  -> pass
> > +# SKIP(3)     -> skip
> > +# ERROR(4)    -> fail
> > +# FAILURE(5)  -> fail
> > +#
> > +sub xtf_result_to_osstest_result ($) {
> > +    my ($xret) = @_;
> > +
> > +    return "pass" if $xret == 0;
> > +    return "skip" if $xret == 3;
> > +    return "fail" if $xret == 4;
> > +    return "fail" if $xret == 5;
> > +    die "xtf runner gave unexpected result $xret";
> 
> Wouldn't it be nicer to delete the separate comment and write
> 
>   +    return "pass" if $xret == 0; # XTF SUCCESS
> 
> etc. ?
> 
> > +    if (! eval {
>             ^
> This space is anomalous coding style.
> 
> 
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

Fixed both issues and added your ack. Thanks.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel