From: Wei Liu <wei.liu2@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [XTF PATCH 3/3] xtf-runner: support two modes for getting output
Date: Thu, 11 Aug 2016 12:19:09 +0100 [thread overview]
Message-ID: <20160811111909.GJ20641@citrix.com> (raw)
In-Reply-To: <22444.23699.895010.962994@mariner.uk.xensource.com>
On Thu, Aug 11, 2016 at 12:08:03PM +0100, Ian Jackson wrote:
> Andrew Cooper writes ("Re: [XTF PATCH 3/3] xtf-runner: support two modes for getting output"):
> > Can't you just open the log file as read, seek to the end, run the test
> > and read again from the same FD? It would be rather more simple than
> > marking the logs.
>
> This is a good suggestion, I think. Much better than mine in my other
> email.
>
> > Sadly, whatever method we use here is going to have to be clever enough
> > to cope with the log files being rotated, and I can't think of a clever
> > way of doing that ATM.
>
> In an automatic test system the logfiles won't get big enough to be
> rotated. In a manual setup this is just a "random hazard" which you
> seem to be prepared to accept...
>
That's what I thought as well.
> But: it is easy for the runner to see if the logfile was rotated. It
> can open the logfile a second time and check if it has the same inum.
>
For now let's keep things simple. Doesn't seem to buy us much even if we
implement this.
Wei.
> Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-08-11 11:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 15:07 [XTF PATCH 0/3] Support getting output from either console or log file Wei Liu
2016-08-10 15:07 ` [XTF PATCH 1/3] xtf-runner: introduce get_xen_version Wei Liu
2016-08-11 10:10 ` Andrew Cooper
2016-08-11 10:12 ` Wei Liu
2016-08-11 10:14 ` Andrew Cooper
2016-08-10 15:07 ` [XTF PATCH 2/3] xtf-runner: options for different modes to get output Wei Liu
2016-08-10 15:07 ` [XTF PATCH 3/3] xtf-runner: support two modes for getting output Wei Liu
2016-08-11 8:33 ` Wei Liu
2016-08-11 9:44 ` Wei Liu
2016-08-11 9:56 ` Andrew Cooper
2016-08-11 10:05 ` Wei Liu
2016-08-11 11:08 ` Ian Jackson
2016-08-11 11:19 ` Wei Liu [this message]
2016-08-11 11:41 ` Andrew Cooper
2016-08-11 10:49 ` Ian Jackson
2016-08-11 11:03 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160811111909.GJ20641@citrix.com \
--to=wei.liu2@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).