Re: [PATCH] gnttab: Add gntdev device mappings for FreeBSD

[Wei Liu <wei.liu2@citrix.com>]

On Sun, Aug 07, 2016 at 03:48:44PM +0530, Akshay Jaggi wrote:
> > > +    int fd = xgt->fd, rc;
> > > +    struct ioctl_gntdev_set_max_grants max_grants = { .count = count };
> > > +
> > > +    rc = ioctl(fd, IOCTL_GNTDEV_SET_MAX_GRANTS, &max_grants);
> > > +    if (rc) {
> >
> > Coding style, the bracket should be on a new line and you need spaces
> > inside
> > the conditional.
> >
> >
> Most code is from linux.c. I modified the code to use appropriate
> definitions from the interface we expose, but left all other things in
> place.
> I went over the code, to fix the style issues, but found some other errors.
> For instance, in function osdep_gntshr_share_pages(), notify_offset and
> notify_port are specified -1 when the user doesn't want these notify
> functions. But there is no such check for notify_offset, and it ends up
> having an unintended consequence on a previous grant (map->index-1 lies on
> a different grant).
> I'll fix this in the freebsd file, and also the linux one and send by
> tonight. :)
> 

Please send a separate patch for linux.c as we probably want to backport
that.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel