From: Wei Liu <wei.liu2@citrix.com>
To: Tamas K Lengyel <tamas.lengyel@zentific.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Sergej Proskurin <proskurin@sec.in.tum.de>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Julien Grall <julien.grall@arm.com>,
Jan Beulich <jbeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel@lists.xenproject.org,
Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: Re: [PATCH v2 2/2] x86/altp2m: allow specifying external-only use-case
Date: Fri, 12 Aug 2016 16:02:45 +0100 [thread overview]
Message-ID: <20160812150245.GL20641@citrix.com> (raw)
In-Reply-To: <CAErYnsj-_LcNDs=6B6cu9_YPoO_X11qcRoc_dhOiy2JGSOYzRA@mail.gmail.com>
On Fri, Aug 12, 2016 at 08:51:14AM -0600, Tamas K Lengyel wrote:
> On Aug 12, 2016 05:24, "Julien Grall" <julien.grall@arm.com> wrote:
> >
> > Hello Tamas,
> >
> >
> > On 10/08/2016 17:00, Tamas K Lengyel wrote:
> >>
> >> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
> >> index ef614be..97948fd 100644
> >> --- a/tools/libxl/libxl_types.idl
> >> +++ b/tools/libxl/libxl_types.idl
> >> @@ -439,6 +439,13 @@ libxl_rdm_reserve = Struct("rdm_reserve", [
> >> ("policy", libxl_rdm_reserve_policy),
> >> ])
> >>
> >> +# Consistent with the values defined for HVM_PARAM_ALTP2M
> >> +libxl_altp2m_mode = Enumeration("altp2m_mode", [
> >> + (0, "disabled"),
> >> + (1, "mixed"),
> >> + (2, "external_only"),
> >> + ], init_val = "LIBXL_ALTP2M_MODE_DISABLED")
> >> +
> >> libxl_domain_build_info = Struct("domain_build_info",[
> >> ("max_vcpus", integer),
> >> ("avail_vcpus", libxl_bitmap),
> >> @@ -512,7 +519,7 @@ libxl_domain_build_info =
> Struct("domain_build_info",[
> >> ("mmio_hole_memkb", MemKB),
> >> ("timer_mode",
> libxl_timer_mode),
> >> ("nested_hvm",
> libxl_defbool),
> >> - ("altp2m",
> libxl_defbool),
> >> + ("altp2m",
> libxl_altp2m_mode),
> >
> >
> > Should we move altp2m directly outside of the structure "hvm" to avoid
> yet another change when altp2m will be supported on ARM? (see [1])
> >
> > Regards,
> >
> > [1] https://lists.xen.org/archives/html/xen-devel/2016-08/msg00147.html
> >
> > --
> > Julien Grall
>
> Hi Julien,
> We can do that here if preferred by the tools maintainers though I'm on the
> opinion that it should be adjusted in the ARM altp2m series once it
> actually becomes available there.
>
I agree. We shouldn't mix things together.
Wei.
> Tamas
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-08-12 15:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 15:00 [PATCH v2 1/2] x86/altp2m: use __get_gfn_type_access to avoid lock conflicts Tamas K Lengyel
2016-08-10 15:00 ` [PATCH v2 2/2] x86/altp2m: allow specifying external-only use-case Tamas K Lengyel
2016-08-11 12:02 ` Jan Beulich
2016-08-11 14:37 ` Tamas K Lengyel
2016-08-11 14:51 ` Jan Beulich
2016-08-16 21:23 ` Daniel De Graaf
2016-08-11 17:17 ` Wei Liu
2016-08-11 17:50 ` Tamas K Lengyel
2016-08-11 17:57 ` Wei Liu
2016-08-12 11:24 ` Julien Grall
2016-08-12 14:51 ` Tamas K Lengyel
2016-08-12 15:02 ` Wei Liu [this message]
2016-08-11 11:57 ` [PATCH v2 1/2] x86/altp2m: use __get_gfn_type_access to avoid lock conflicts Jan Beulich
2016-08-31 21:02 ` Tamas K Lengyel
2016-09-06 17:02 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160812150245.GL20641@citrix.com \
--to=wei.liu2@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=proskurin@sec.in.tum.de \
--cc=tamas.lengyel@zentific.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).