From: Wei Liu <wei.liu2@citrix.com>
To: Minios-devel <minios-devel@lists.xenproject.org>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>,
Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: Re: [MINIOS PATCH 4/4] x86: use unified linker script
Date: Wed, 17 Aug 2016 13:37:04 +0100 [thread overview]
Message-ID: <20160817123704.GY20641@citrix.com> (raw)
In-Reply-To: <1471437314-29256-5-git-send-email-wei.liu2@citrix.com>
On Wed, Aug 17, 2016 at 01:35:14PM +0100, Wei Liu wrote:
> There are only a few differences between i386 and x86-64 linker scripts.
> Unify them into one. Re-indent the file at the same time.
>
> Construct a special rule in top-level directory to cope with the change.
> Ideally the build system should also be made more elegant, but
> overhauling the build system is out of scope of this patch.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
[...]
> + /* newlib initialization functions */
> +#if defined(__x86_64__)
> + . = ALIGN(64 / 8);
> +#else /* __i386 __ */
> + . = ALIGN(64 / 8);
Oops, this should be 32 / 8.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-08-17 12:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 12:35 [MINIOS PATCH 0/4] x86: Use ELF notes and unfied linker script Wei Liu
2016-08-17 12:35 ` [MINIOS PATCH 1/4] gitignore: ignore vim swap file Wei Liu
2016-08-17 12:51 ` Samuel Thibault
2016-08-18 10:13 ` Wei Liu
2016-08-17 12:35 ` [MINIOS PATCH 2/4] Introduce asm_macros.h Wei Liu
2016-08-17 12:56 ` Samuel Thibault
2016-08-17 13:40 ` Wei Liu
2016-08-17 13:44 ` Wei Liu
2016-08-17 13:49 ` Andrew Cooper
2016-08-17 14:01 ` Andrew Cooper
2016-08-17 14:03 ` Wei Liu
2016-08-17 14:05 ` Wei Liu
2016-08-17 12:35 ` [MINIOS PATCH 3/4] x86: switch to use elfnote Wei Liu
2016-08-17 14:00 ` [Minios-devel] " Juergen Gross
2016-08-17 12:35 ` [MINIOS PATCH 4/4] x86: use unified linker script Wei Liu
2016-08-17 12:37 ` Wei Liu [this message]
2016-08-17 12:52 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160817123704.GY20641@citrix.com \
--to=wei.liu2@citrix.com \
--cc=minios-devel@lists.xenproject.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).