From: Wei Liu <wei.liu2@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com>,
George Dunlap <george.dunlap@citrix.com>
Subject: Re: [PATCH] tools/xenalyze: append argp LD flags if needed
Date: Thu, 18 Aug 2016 10:49:12 +0100 [thread overview]
Message-ID: <20160818094912.GI20641@citrix.com> (raw)
In-Reply-To: <1471511444-44780-1-git-send-email-roger.pau@citrix.com>
On Thu, Aug 18, 2016 at 11:10:44AM +0200, Roger Pau Monne wrote:
> This is a side-effect of commit c36e1c, which currently prevents compiling
> xenalyze with libcs that don't have argp built-in.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Cc: George Dunlap <george.dunlap@citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> ---
> tools/xentrace/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/xentrace/Makefile b/tools/xentrace/Makefile
> index a85ed33..c8c36a8 100644
> --- a/tools/xentrace/Makefile
> +++ b/tools/xentrace/Makefile
> @@ -50,7 +50,7 @@ xentrace_setsize: setsize.o
> $(CC) $(LDFLAGS) -o $@ $< $(LDLIBS) $(APPEND_LDFLAGS)
>
> xenalyze: xenalyze.o mread.o
> - $(CC) $(LDFLAGS) -o $@ $^ $(APPEND_LDFLAGS)
> + $(CC) $(LDFLAGS) -o $@ $^ $(ARGP_LDFLAGS) $(APPEND_LDFLAGS)
>
> -include $(DEPS)
>
> --
> 2.7.4 (Apple Git-66)
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-08-18 9:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 9:10 [PATCH] tools/xenalyze: append argp LD flags if needed Roger Pau Monne
2016-08-18 9:40 ` George Dunlap
2016-08-18 9:49 ` Wei Liu [this message]
2016-08-18 16:24 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160818094912.GI20641@citrix.com \
--to=wei.liu2@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).