* [PATCH] tools/xenalyze: append argp LD flags if needed
@ 2016-08-18 9:10 Roger Pau Monne
2016-08-18 9:40 ` George Dunlap
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Roger Pau Monne @ 2016-08-18 9:10 UTC (permalink / raw)
To: xen-devel; +Cc: Ian Jackson, Wei Liu, George Dunlap, Roger Pau Monne
This is a side-effect of commit c36e1c, which currently prevents compiling
xenalyze with libcs that don't have argp built-in.
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: George Dunlap <george.dunlap@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
---
tools/xentrace/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/xentrace/Makefile b/tools/xentrace/Makefile
index a85ed33..c8c36a8 100644
--- a/tools/xentrace/Makefile
+++ b/tools/xentrace/Makefile
@@ -50,7 +50,7 @@ xentrace_setsize: setsize.o
$(CC) $(LDFLAGS) -o $@ $< $(LDLIBS) $(APPEND_LDFLAGS)
xenalyze: xenalyze.o mread.o
- $(CC) $(LDFLAGS) -o $@ $^ $(APPEND_LDFLAGS)
+ $(CC) $(LDFLAGS) -o $@ $^ $(ARGP_LDFLAGS) $(APPEND_LDFLAGS)
-include $(DEPS)
--
2.7.4 (Apple Git-66)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] tools/xenalyze: append argp LD flags if needed
2016-08-18 9:10 [PATCH] tools/xenalyze: append argp LD flags if needed Roger Pau Monne
@ 2016-08-18 9:40 ` George Dunlap
2016-08-18 9:49 ` Wei Liu
2016-08-18 16:24 ` Wei Liu
2 siblings, 0 replies; 4+ messages in thread
From: George Dunlap @ 2016-08-18 9:40 UTC (permalink / raw)
To: Roger Pau Monne, xen-devel; +Cc: Ian Jackson, Wei Liu
On 18/08/16 10:10, Roger Pau Monne wrote:
> This is a side-effect of commit c36e1c, which currently prevents compiling
> xenalyze with libcs that don't have argp built-in.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
I don't have the expertise to know if this is the Right Way to solve
this problem; but regarding the principle:
Acked-by: George Dunlap <george.dunlap@citrix.com>
> ---
> Cc: George Dunlap <george.dunlap@citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> ---
> tools/xentrace/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/xentrace/Makefile b/tools/xentrace/Makefile
> index a85ed33..c8c36a8 100644
> --- a/tools/xentrace/Makefile
> +++ b/tools/xentrace/Makefile
> @@ -50,7 +50,7 @@ xentrace_setsize: setsize.o
> $(CC) $(LDFLAGS) -o $@ $< $(LDLIBS) $(APPEND_LDFLAGS)
>
> xenalyze: xenalyze.o mread.o
> - $(CC) $(LDFLAGS) -o $@ $^ $(APPEND_LDFLAGS)
> + $(CC) $(LDFLAGS) -o $@ $^ $(ARGP_LDFLAGS) $(APPEND_LDFLAGS)
>
> -include $(DEPS)
>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tools/xenalyze: append argp LD flags if needed
2016-08-18 9:10 [PATCH] tools/xenalyze: append argp LD flags if needed Roger Pau Monne
2016-08-18 9:40 ` George Dunlap
@ 2016-08-18 9:49 ` Wei Liu
2016-08-18 16:24 ` Wei Liu
2 siblings, 0 replies; 4+ messages in thread
From: Wei Liu @ 2016-08-18 9:49 UTC (permalink / raw)
To: Roger Pau Monne; +Cc: Ian Jackson, xen-devel, Wei Liu, George Dunlap
On Thu, Aug 18, 2016 at 11:10:44AM +0200, Roger Pau Monne wrote:
> This is a side-effect of commit c36e1c, which currently prevents compiling
> xenalyze with libcs that don't have argp built-in.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Cc: George Dunlap <george.dunlap@citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> ---
> tools/xentrace/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/xentrace/Makefile b/tools/xentrace/Makefile
> index a85ed33..c8c36a8 100644
> --- a/tools/xentrace/Makefile
> +++ b/tools/xentrace/Makefile
> @@ -50,7 +50,7 @@ xentrace_setsize: setsize.o
> $(CC) $(LDFLAGS) -o $@ $< $(LDLIBS) $(APPEND_LDFLAGS)
>
> xenalyze: xenalyze.o mread.o
> - $(CC) $(LDFLAGS) -o $@ $^ $(APPEND_LDFLAGS)
> + $(CC) $(LDFLAGS) -o $@ $^ $(ARGP_LDFLAGS) $(APPEND_LDFLAGS)
>
> -include $(DEPS)
>
> --
> 2.7.4 (Apple Git-66)
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tools/xenalyze: append argp LD flags if needed
2016-08-18 9:10 [PATCH] tools/xenalyze: append argp LD flags if needed Roger Pau Monne
2016-08-18 9:40 ` George Dunlap
2016-08-18 9:49 ` Wei Liu
@ 2016-08-18 16:24 ` Wei Liu
2 siblings, 0 replies; 4+ messages in thread
From: Wei Liu @ 2016-08-18 16:24 UTC (permalink / raw)
To: Roger Pau Monne; +Cc: Ian Jackson, xen-devel, Wei Liu, George Dunlap
Queued.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-18 16:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-18 9:10 [PATCH] tools/xenalyze: append argp LD flags if needed Roger Pau Monne
2016-08-18 9:40 ` George Dunlap
2016-08-18 9:49 ` Wei Liu
2016-08-18 16:24 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).