From: Wei Liu <wei.liu2@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>, Jan Beulich <JBeulich@suse.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v8 07/13] hvmloader: Locate the BIOS blob
Date: Thu, 18 Aug 2016 16:51:00 +0100 [thread overview]
Message-ID: <20160818155100.GN20641@citrix.com> (raw)
In-Reply-To: <428fc67e-bbc0-5bfc-c824-7c1e0b113d96@citrix.com>
On Thu, Aug 18, 2016 at 04:48:20PM +0100, Andrew Cooper wrote:
> On 18/08/16 16:39, Jan Beulich wrote:
> >>>> On 18.08.16 at 16:13, <wei.liu2@citrix.com> wrote:
> >> From: Anthony PERARD <anthony.perard@citrix.com>
> >>
> >> The BIOS blob can be found an entry called "firmware" of the modlist of
> >> the hvm_start_info struct.
> >>
> >> The found BIOS blob is not loaded by this patch, but only passed as
> >> argument to bios_load() function.
> >>
> >> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> > Acked-by: Jan Beulich <jbeulich@suse.com>
> > provided Andrew confirms his concerns have got addressed and a
> > few minor things get taken care of:
>
> They haven't, but I am planning some fixes anyway, so I will adjust
> things there. They are not worth letting this series drag on even longer.
>
Can I turn this into an ack?
I can fix the issues Jan pointed out why committing.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-08-18 15:51 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 14:13 [PATCH v8 00/13] Load BIOS via toolstack instead of been embedded in hvmloader Wei Liu
2016-08-18 14:13 ` [PATCH v8 01/13] libxc: Rework extra module initialisation Wei Liu
2016-08-18 14:13 ` [PATCH v8 02/13] libxc: Prepare a start info structure for hvmloader Wei Liu
2016-08-18 14:13 ` [PATCH v8 03/13] configure: #define SEABIOS_PATH and OVMF_PATH Wei Liu
2016-08-18 14:13 ` [PATCH v8 04/13] firmware/makefile: install BIOS blob Wei Liu
2016-08-18 14:13 ` [PATCH v8 05/13] libxl: Load guest BIOS from file Wei Liu
2016-08-19 14:43 ` Andrew Cooper
2016-08-22 13:13 ` Wei Liu
2016-08-22 13:26 ` Andrew Cooper
2016-08-22 14:26 ` Wei Liu
2016-08-22 15:05 ` [PATCH 0/2] Fix issue with {OVMF,SEABIOS}_PATH Wei Liu
2016-08-22 15:05 ` [PATCH 1/2] tools: only define {OVMF, SEABIOS}_PATH when they are enabled Wei Liu
2016-08-22 15:05 ` [PATCH 2/2] libxl: only return {OVMF, SEABIOS}_PATH if available Wei Liu
2016-08-23 9:37 ` [PATCH 0/2] Fix issue with {OVMF,SEABIOS}_PATH Andrew Cooper
2016-08-24 11:38 ` Ian Jackson
2016-08-24 11:59 ` Wei Liu
2016-08-22 15:09 ` [PATCH v8 05/13] libxl: Load guest BIOS from file Andrew Cooper
2016-08-22 15:13 ` Wei Liu
2016-08-23 20:00 ` Doug Goldstein
2016-08-24 9:16 ` Wei Liu
2016-08-18 14:13 ` [PATCH v8 06/13] hvmloader: Grab the hvm_start_info pointer Wei Liu
2016-08-18 14:13 ` [PATCH v8 07/13] hvmloader: Locate the BIOS blob Wei Liu
2016-08-18 15:39 ` Jan Beulich
2016-08-18 15:48 ` Andrew Cooper
2016-08-18 15:51 ` Wei Liu [this message]
2016-08-18 14:13 ` [PATCH v8 08/13] hvmloader: Load SeaBIOS from hvm_start_info modules Wei Liu
2016-08-18 14:13 ` [PATCH v8 09/13] hvmloader: Load OVMF from modules Wei Liu
2016-08-18 14:13 ` [PATCH v8 10/13] hvmloader: bios->bios_load() now needs to be defined Wei Liu
2016-08-18 14:13 ` [PATCH v8 11/13] hvmloader: Always build-in SeaBIOS and OVMF loader Wei Liu
2016-08-18 14:13 ` [PATCH v8 12/13] configure: do not depend on SEABIOS_PATH or OVMF_PATH Wei Liu
2016-08-18 14:13 ` [PATCH v8 13/13] docs/misc/hvmlite: Point to the canonical definition of hvm_start_info Wei Liu
2016-08-18 16:23 ` [PATCH v8 00/13] Load BIOS via toolstack instead of been embedded in hvmloader Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160818155100.GN20641@citrix.com \
--to=wei.liu2@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).