* [PATCH] arm64: head: Fill image size
@ 2016-08-16 2:58 Peng Fan
2016-08-18 16:02 ` Julien Grall
0 siblings, 1 reply; 3+ messages in thread
From: Peng Fan @ 2016-08-16 2:58 UTC (permalink / raw)
To: sstabellini, julien.grall; +Cc: van.freenix, xen-devel
When booting xen from U-Boot, U-Boot will use the image size
info. Because this information is lacked in XEN image,U-Boot
assume the image size is 16MB to memmove, which will cost lots
time on simulation platform.
Signed-off-by: Peng Fan <van.freenix@gmail.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Julien Grall <julien.grall@arm.com>
---
xen/arch/arm/arm64/head.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
index 91e2817..9fade07 100644
--- a/xen/arch/arm/arm64/head.S
+++ b/xen/arch/arm/arm64/head.S
@@ -115,7 +115,7 @@ efi_head:
add x13, x18, #0x16
b real_start /* branch to kernel start */
.quad 0 /* Image load offset from start of RAM */
- .quad 0 /* reserved */
+ .quad _end - start /* Effective size of Image, little-endian */
.quad 0 /* reserved */
.quad 0 /* reserved */
.quad 0 /* reserved */
--
2.6.2
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: head: Fill image size
2016-08-16 2:58 [PATCH] arm64: head: Fill image size Peng Fan
@ 2016-08-18 16:02 ` Julien Grall
2016-08-19 12:13 ` Peng Fan
0 siblings, 1 reply; 3+ messages in thread
From: Julien Grall @ 2016-08-18 16:02 UTC (permalink / raw)
To: Peng Fan, sstabellini; +Cc: xen-devel
Hello Peng,
On 16/08/16 03:58, Peng Fan wrote:
> When booting xen from U-Boot, U-Boot will use the image size
> info. Because this information is lacked in XEN image,U-Boot
> assume the image size is 16MB to memmove, which will cost lots
> time on simulation platform.
The patch looks good to me, however I would prefer if you update all the
header rather than updating only the field you care.
You can give a look to commit a2c1d73b94ed49f5fac12e95052d7b140783f800
"arm64: Update the Image header" in Linux for more details.
Regards,
>
> Signed-off-by: Peng Fan <van.freenix@gmail.com>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: Julien Grall <julien.grall@arm.com>
> ---
> xen/arch/arm/arm64/head.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
> index 91e2817..9fade07 100644
> --- a/xen/arch/arm/arm64/head.S
> +++ b/xen/arch/arm/arm64/head.S
> @@ -115,7 +115,7 @@ efi_head:
> add x13, x18, #0x16
> b real_start /* branch to kernel start */
> .quad 0 /* Image load offset from start of RAM */
> - .quad 0 /* reserved */
> + .quad _end - start /* Effective size of Image, little-endian */
> .quad 0 /* reserved */
> .quad 0 /* reserved */
> .quad 0 /* reserved */
>
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: head: Fill image size
2016-08-18 16:02 ` Julien Grall
@ 2016-08-19 12:13 ` Peng Fan
0 siblings, 0 replies; 3+ messages in thread
From: Peng Fan @ 2016-08-19 12:13 UTC (permalink / raw)
To: Julien Grall; +Cc: sstabellini, xen-devel
Hi Julien,
On Thu, Aug 18, 2016 at 05:02:01PM +0100, Julien Grall wrote:
>Hello Peng,
>
>On 16/08/16 03:58, Peng Fan wrote:
>>When booting xen from U-Boot, U-Boot will use the image size
>>info. Because this information is lacked in XEN image,U-Boot
>>assume the image size is 16MB to memmove, which will cost lots
>>time on simulation platform.
>
>The patch looks good to me, however I would prefer if you update all the
>header rather than updating only the field you care.
>
>You can give a look to commit a2c1d73b94ed49f5fac12e95052d7b140783f800
>"arm64: Update the Image header" in Linux for more details.
Thanks for comments. Will do this in V2.
Thanks,
Peng.
>
>Regards,
>
>>
>>Signed-off-by: Peng Fan <van.freenix@gmail.com>
>>Cc: Stefano Stabellini <sstabellini@kernel.org>
>>Cc: Julien Grall <julien.grall@arm.com>
>>---
>> xen/arch/arm/arm64/head.S | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
>>index 91e2817..9fade07 100644
>>--- a/xen/arch/arm/arm64/head.S
>>+++ b/xen/arch/arm/arm64/head.S
>>@@ -115,7 +115,7 @@ efi_head:
>> add x13, x18, #0x16
>> b real_start /* branch to kernel start */
>> .quad 0 /* Image load offset from start of RAM */
>>- .quad 0 /* reserved */
>>+ .quad _end - start /* Effective size of Image, little-endian */
>> .quad 0 /* reserved */
>> .quad 0 /* reserved */
>> .quad 0 /* reserved */
>>
>
>--
>Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-19 12:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-16 2:58 [PATCH] arm64: head: Fill image size Peng Fan
2016-08-18 16:02 ` Julien Grall
2016-08-19 12:13 ` Peng Fan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).