From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] x86/mm: drop pointless use of __FUNCTION__
Date: Wed, 24 Aug 2016 16:37:13 -0400 [thread overview]
Message-ID: <20160824203713.GE23337@char.us.oracle.com> (raw)
In-Reply-To: <57BD706502000078001087A9@prv-mh.provo.novell.com>
On Wed, Aug 24, 2016 at 02:01:09AM -0600, Jan Beulich wrote:
> Non-debugging message text should be (and is here) distinguishable
> without also logging function names.
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/arch/x86/mm/paging.c
> +++ b/xen/arch/x86/mm/paging.c
> @@ -469,8 +469,9 @@ static int paging_log_dirty_op(struct do
> peek = 0;
>
> if ( unlikely(d->arch.paging.log_dirty.failed_allocs) ) {
> - printk("%s: %d failed page allocs while logging dirty pages\n",
> - __FUNCTION__, d->arch.paging.log_dirty.failed_allocs);
> + printk(XENLOG_WARNING
> + "%u failed page allocs while logging dirty pages of Dom%d\n",
> + d->arch.paging.log_dirty.failed_allocs, d->domain_id);
> rv = -ENOMEM;
> goto out;
> }
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-08-24 20:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 8:01 [PATCH] x86/mm: drop pointless use of __FUNCTION__ Jan Beulich
2016-08-24 20:37 ` Konrad Rzeszutek Wilk [this message]
2016-08-31 18:39 ` Andrew Cooper
2016-09-01 7:13 ` Jan Beulich
2016-09-01 9:52 ` Andrew Cooper
2016-09-02 10:52 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160824203713.GE23337@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).