* [PATCH] x86/mm: drop pointless use of __FUNCTION__
@ 2016-08-24 8:01 Jan Beulich
2016-08-24 20:37 ` Konrad Rzeszutek Wilk
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Jan Beulich @ 2016-08-24 8:01 UTC (permalink / raw)
To: xen-devel; +Cc: George Dunlap
[-- Attachment #1: Type: text/plain, Size: 758 bytes --]
Non-debugging message text should be (and is here) distinguishable
without also logging function names.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/mm/paging.c
+++ b/xen/arch/x86/mm/paging.c
@@ -469,8 +469,9 @@ static int paging_log_dirty_op(struct do
peek = 0;
if ( unlikely(d->arch.paging.log_dirty.failed_allocs) ) {
- printk("%s: %d failed page allocs while logging dirty pages\n",
- __FUNCTION__, d->arch.paging.log_dirty.failed_allocs);
+ printk(XENLOG_WARNING
+ "%u failed page allocs while logging dirty pages of Dom%d\n",
+ d->arch.paging.log_dirty.failed_allocs, d->domain_id);
rv = -ENOMEM;
goto out;
}
[-- Attachment #2: x86-mm-drop-__FUNCTION__.patch --]
[-- Type: text/plain, Size: 798 bytes --]
x86/mm: drop pointless use of __FUNCTION__
Non-debugging message text should be (and is here) distinguishable
without also logging function names.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/mm/paging.c
+++ b/xen/arch/x86/mm/paging.c
@@ -469,8 +469,9 @@ static int paging_log_dirty_op(struct do
peek = 0;
if ( unlikely(d->arch.paging.log_dirty.failed_allocs) ) {
- printk("%s: %d failed page allocs while logging dirty pages\n",
- __FUNCTION__, d->arch.paging.log_dirty.failed_allocs);
+ printk(XENLOG_WARNING
+ "%u failed page allocs while logging dirty pages of Dom%d\n",
+ d->arch.paging.log_dirty.failed_allocs, d->domain_id);
rv = -ENOMEM;
goto out;
}
[-- Attachment #3: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] x86/mm: drop pointless use of __FUNCTION__
2016-08-24 8:01 [PATCH] x86/mm: drop pointless use of __FUNCTION__ Jan Beulich
@ 2016-08-24 20:37 ` Konrad Rzeszutek Wilk
2016-08-31 18:39 ` Andrew Cooper
2016-09-02 10:52 ` George Dunlap
2 siblings, 0 replies; 6+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-08-24 20:37 UTC (permalink / raw)
To: Jan Beulich; +Cc: George Dunlap, xen-devel
On Wed, Aug 24, 2016 at 02:01:09AM -0600, Jan Beulich wrote:
> Non-debugging message text should be (and is here) distinguishable
> without also logging function names.
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/arch/x86/mm/paging.c
> +++ b/xen/arch/x86/mm/paging.c
> @@ -469,8 +469,9 @@ static int paging_log_dirty_op(struct do
> peek = 0;
>
> if ( unlikely(d->arch.paging.log_dirty.failed_allocs) ) {
> - printk("%s: %d failed page allocs while logging dirty pages\n",
> - __FUNCTION__, d->arch.paging.log_dirty.failed_allocs);
> + printk(XENLOG_WARNING
> + "%u failed page allocs while logging dirty pages of Dom%d\n",
> + d->arch.paging.log_dirty.failed_allocs, d->domain_id);
> rv = -ENOMEM;
> goto out;
> }
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] x86/mm: drop pointless use of __FUNCTION__
2016-08-24 8:01 [PATCH] x86/mm: drop pointless use of __FUNCTION__ Jan Beulich
2016-08-24 20:37 ` Konrad Rzeszutek Wilk
@ 2016-08-31 18:39 ` Andrew Cooper
2016-09-01 7:13 ` Jan Beulich
2016-09-02 10:52 ` George Dunlap
2 siblings, 1 reply; 6+ messages in thread
From: Andrew Cooper @ 2016-08-31 18:39 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: George Dunlap
On 24/08/16 09:01, Jan Beulich wrote:
> Non-debugging message text should be (and is here) distinguishable
> without also logging function names.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/arch/x86/mm/paging.c
> +++ b/xen/arch/x86/mm/paging.c
> @@ -469,8 +469,9 @@ static int paging_log_dirty_op(struct do
> peek = 0;
>
> if ( unlikely(d->arch.paging.log_dirty.failed_allocs) ) {
> - printk("%s: %d failed page allocs while logging dirty pages\n",
> - __FUNCTION__, d->arch.paging.log_dirty.failed_allocs);
> + printk(XENLOG_WARNING
> + "%u failed page allocs while logging dirty pages of Dom%d\n",
> + d->arch.paging.log_dirty.failed_allocs, d->domain_id);
Can we standardise on d%d instead? It is shorter, and mutually
consistent with d%dv%d for vcpus.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] x86/mm: drop pointless use of __FUNCTION__
2016-08-31 18:39 ` Andrew Cooper
@ 2016-09-01 7:13 ` Jan Beulich
2016-09-01 9:52 ` Andrew Cooper
0 siblings, 1 reply; 6+ messages in thread
From: Jan Beulich @ 2016-09-01 7:13 UTC (permalink / raw)
To: Andrew Cooper; +Cc: George Dunlap, xen-devel
>>> On 31.08.16 at 20:39, <andrew.cooper3@citrix.com> wrote:
> On 24/08/16 09:01, Jan Beulich wrote:
>> Non-debugging message text should be (and is here) distinguishable
>> without also logging function names.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>
>> --- a/xen/arch/x86/mm/paging.c
>> +++ b/xen/arch/x86/mm/paging.c
>> @@ -469,8 +469,9 @@ static int paging_log_dirty_op(struct do
>> peek = 0;
>>
>> if ( unlikely(d->arch.paging.log_dirty.failed_allocs) ) {
>> - printk("%s: %d failed page allocs while logging dirty pages\n",
>> - __FUNCTION__, d->arch.paging.log_dirty.failed_allocs);
>> + printk(XENLOG_WARNING
>> + "%u failed page allocs while logging dirty pages of Dom%d\n",
>> + d->arch.paging.log_dirty.failed_allocs, d->domain_id);
>
> Can we standardise on d%d instead? It is shorter, and mutually
> consistent with d%dv%d for vcpus.
Fine with me - done.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] x86/mm: drop pointless use of __FUNCTION__
2016-09-01 7:13 ` Jan Beulich
@ 2016-09-01 9:52 ` Andrew Cooper
0 siblings, 0 replies; 6+ messages in thread
From: Andrew Cooper @ 2016-09-01 9:52 UTC (permalink / raw)
To: Jan Beulich; +Cc: George Dunlap, xen-devel
On 01/09/16 08:13, Jan Beulich wrote:
>>>> On 31.08.16 at 20:39, <andrew.cooper3@citrix.com> wrote:
>> On 24/08/16 09:01, Jan Beulich wrote:
>>> Non-debugging message text should be (and is here) distinguishable
>>> without also logging function names.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>
>>> --- a/xen/arch/x86/mm/paging.c
>>> +++ b/xen/arch/x86/mm/paging.c
>>> @@ -469,8 +469,9 @@ static int paging_log_dirty_op(struct do
>>> peek = 0;
>>>
>>> if ( unlikely(d->arch.paging.log_dirty.failed_allocs) ) {
>>> - printk("%s: %d failed page allocs while logging dirty pages\n",
>>> - __FUNCTION__, d->arch.paging.log_dirty.failed_allocs);
>>> + printk(XENLOG_WARNING
>>> + "%u failed page allocs while logging dirty pages of Dom%d\n",
>>> + d->arch.paging.log_dirty.failed_allocs, d->domain_id);
>> Can we standardise on d%d instead? It is shorter, and mutually
>> consistent with d%dv%d for vcpus.
> Fine with me - done.
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86/mm: drop pointless use of __FUNCTION__
2016-08-24 8:01 [PATCH] x86/mm: drop pointless use of __FUNCTION__ Jan Beulich
2016-08-24 20:37 ` Konrad Rzeszutek Wilk
2016-08-31 18:39 ` Andrew Cooper
@ 2016-09-02 10:52 ` George Dunlap
2 siblings, 0 replies; 6+ messages in thread
From: George Dunlap @ 2016-09-02 10:52 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel
On Wed, Aug 24, 2016 at 9:01 AM, Jan Beulich <JBeulich@suse.com> wrote:
> Non-debugging message text should be (and is here) distinguishable
> without also logging function names.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: George Dunlap <george.dunlap@citrix.com>
>
> --- a/xen/arch/x86/mm/paging.c
> +++ b/xen/arch/x86/mm/paging.c
> @@ -469,8 +469,9 @@ static int paging_log_dirty_op(struct do
> peek = 0;
>
> if ( unlikely(d->arch.paging.log_dirty.failed_allocs) ) {
> - printk("%s: %d failed page allocs while logging dirty pages\n",
> - __FUNCTION__, d->arch.paging.log_dirty.failed_allocs);
> + printk(XENLOG_WARNING
> + "%u failed page allocs while logging dirty pages of Dom%d\n",
> + d->arch.paging.log_dirty.failed_allocs, d->domain_id);
> rv = -ENOMEM;
> goto out;
> }
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-02 10:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-24 8:01 [PATCH] x86/mm: drop pointless use of __FUNCTION__ Jan Beulich
2016-08-24 20:37 ` Konrad Rzeszutek Wilk
2016-08-31 18:39 ` Andrew Cooper
2016-09-01 7:13 ` Jan Beulich
2016-09-01 9:52 ` Andrew Cooper
2016-09-02 10:52 ` George Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).