From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86: correct PT_NOTE file position
Date: Wed, 24 Aug 2016 16:45:34 -0400 [thread overview]
Message-ID: <20160824204534.GF23337@char.us.oracle.com> (raw)
In-Reply-To: <57BDD8560200007800108B7C@prv-mh.provo.novell.com>
On Wed, Aug 24, 2016 at 09:24:38AM -0600, Jan Beulich wrote:
> Program and section headers disagreed about the file offset at which
> the build ID note lives.
Gosh. That was an oversight.
>
> Reported-by: Sylvain Munaut <s.munaut@whatever-company.com>
'whatever-company'? Really?
Huh. Imagine that.
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>
> --- a/xen/arch/x86/boot/mkelf32.c
> +++ b/xen/arch/x86/boot/mkelf32.c
> @@ -394,7 +394,7 @@ int main(int argc, char **argv)
> note_phdr.p_paddr = note_base;
> note_phdr.p_filesz = note_sz;
> note_phdr.p_memsz = note_sz;
> - note_phdr.p_offset = offset;
> + note_phdr.p_offset = RAW_OFFSET + offset;
>
> /* Tack on the .note\0 */
> out_shdr[2].sh_size += sizeof(out_shstrtab_extra);
>
>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-08-24 20:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 15:24 [PATCH] x86: correct PT_NOTE file position Jan Beulich
2016-08-24 20:45 ` Konrad Rzeszutek Wilk [this message]
2016-09-02 10:48 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160824204534.GF23337@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).