Re: [PATCH v4 05/16] libxl/arm: Construct ACPI RSDP table

[Wei Liu <wei.liu2@citrix.com>]

On Thu, Aug 25, 2016 at 04:05:46PM +0800, Shannon Zhao wrote:
> 
> 
> On 2016/8/24 20:52, Wei Liu wrote:
> > On Tue, Aug 16, 2016 at 06:25:02PM +0800, Shannon Zhao wrote:
> >> > From: Shannon Zhao <shannon.zhao@linaro.org>
> >> > 
> >> > Construct ACPI RSDP table and add a helper to calculate the ACPI table
> >> > checksum.
> >> > 
> >> > Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
> >> > ---
> >> >  tools/libxl/libxl_arm_acpi.c | 38 ++++++++++++++++++++++++++++++++++++++
> >> >  1 file changed, 38 insertions(+)
> >> > 
> >> > diff --git a/tools/libxl/libxl_arm_acpi.c b/tools/libxl/libxl_arm_acpi.c
> >> > index 6be9eb0..9432e44 100644
> >> > --- a/tools/libxl/libxl_arm_acpi.c
> >> > +++ b/tools/libxl/libxl_arm_acpi.c
> >> > @@ -33,6 +33,9 @@ extern const unsigned char dsdt_anycpu_arm[];
> >> >  _hidden
> >> >  extern const int dsdt_anycpu_arm_len;
> >> >  
> >> > +#define ACPI_BUILD_APPNAME6 "XenARM"
> >> > +#define ACPI_BUILD_APPNAME4 "Xen "
> >> > +
> > Where do these come from? If they are from a spec, could you please add
> > a comment here?
> > 
> Not from some spec. Just fake a OEM for these tables like the
> ACPI_OEM_ID, ACPI_CREATOR_ID used by x86.
> 

OK.  I'm no expert of ACPI, so if that's how things are done, I am fine
with that.

Wei.

> Thanks,
> -- 
> Shannon
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel