xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Juergen Gross <jgross@suse.com>
Cc: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org, wei.liu2@citrix.com
Subject: Re: [PATCH 3/3] mini-os: remove unused functions from sched.c
Date: Fri, 26 Aug 2016 19:34:36 +0200	[thread overview]
Message-ID: <20160826173436.GB5165@var> (raw)
In-Reply-To: <1472222136-1177-4-git-send-email-jgross@suse.com>

Juergen Gross, on Fri 26 Aug 2016 16:35:36 +0200, wrote:
> sched.c contains some functions nobody is using. Remove them.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> ---
>  sched.c | 48 ------------------------------------------------
>  1 file changed, 48 deletions(-)
> 
> diff --git a/sched.c b/sched.c
> index 1e843d9..6f89ea4 100644
> --- a/sched.c
> +++ b/sched.c
> @@ -63,16 +63,6 @@ static int threads_started;
>  
>  struct thread *main_thread;
>  
> -void inline print_runqueue(void)
> -{
> -    struct thread *th;
> -    MINIOS_TAILQ_FOREACH(th, &thread_list, thread_list)
> -    {
> -        printk("   Thread \"%s\", runnable=%d\n", th->name, is_runnable(th));
> -    }
> -    printk("\n");
> -}
> -
>  void schedule(void)
>  {
>      struct thread *prev, *next, *thread, *tmp;
> @@ -245,44 +235,6 @@ void idle_thread_fn(void *unused)
>      }
>  }
>  
> -DECLARE_MUTEX(mutex);
> -
> -void th_f1(void *data)
> -{
> -    struct timeval tv1, tv2;
> -
> -    for(;;)
> -    {
> -        down(&mutex);
> -        printk("Thread \"%s\" got semaphore, runnable %d\n", current->name, is_runnable(current));
> -        schedule();
> -        printk("Thread \"%s\" releases the semaphore\n", current->name);
> -        up(&mutex);
> -        
> -        
> -        gettimeofday(&tv1, NULL);
> -        for(;;)
> -        {
> -            gettimeofday(&tv2, NULL);
> -            if(tv2.tv_sec - tv1.tv_sec > 2) break;
> -        }
> -                
> -        
> -        schedule(); 
> -    }
> -}
> -
> -void th_f2(void *data)
> -{
> -    for(;;)
> -    {
> -        printk("Thread OTHER executing, data 0x%p\n", data);
> -        schedule();
> -    }
> -}
> -
> -
> -
>  void init_sched(void)
>  {
>      printk("Initialising scheduler\n");
> -- 
> 2.6.6
> 

-- 
Samuel
<b> lisons de l'assembleur c
 -+- #sos - CrisC forever -+-

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

      reply	other threads:[~2016-08-26 17:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-26 14:35 [PATCH 0/3] mini-os: some cleanups Juergen Gross
2016-08-26 14:35 ` [PATCH 1/3] mini-os: cleanup x86_32.S Juergen Gross
2016-08-26 17:33   ` Samuel Thibault
2016-08-26 14:35 ` [PATCH 2/3] mini-os: cleanup x86_64.S Juergen Gross
2016-08-26 14:46   ` Andrew Cooper
2016-08-26 14:54     ` Juergen Gross
2016-08-26 14:35 ` [PATCH 3/3] mini-os: remove unused functions from sched.c Juergen Gross
2016-08-26 17:34   ` Samuel Thibault [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160826173436.GB5165@var \
    --to=samuel.thibault@ens-lyon.org \
    --cc=jgross@suse.com \
    --cc=minios-devel@lists.xenproject.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).