From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Julien Grall <julien.grall@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH 2/4] arm64: use "b" to branch to start_xen
Date: Tue, 30 Aug 2016 09:28:46 -0400 [thread overview]
Message-ID: <20160830132846.GC12888@char.us.oracle.com> (raw)
In-Reply-To: <1472558492-22273-3-git-send-email-wei.liu2@citrix.com>
On Tue, Aug 30, 2016 at 01:01:30PM +0100, Wei Liu wrote:
> The cbz instruction has range limitation. When compiled with gcov
> support the object is larger so cbz can't handle that anymore. The error
> message is like:
>
> aarch64-linux-gnu-ld -EL -T xen.lds -N prelink.o \
> /local/work/xen.git/xen/common/symbols-dummy.o -o /local/work/xen.git/xen/.xen-syms.0
> prelink.o: In function `launch':
> /local/work/xen.git/xen/arch/arm/arm64/head.S:602:(.text+0x408): relocation truncated to fit: R_AARCH64_CONDBR19 against symbol `start_xen' defined in .init.text section in prelink.o
>
> Use "b" instead.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Compile test only.
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: Julien Grall <julien.grall@arm.com>
> ---
> xen/arch/arm/arm64/head.S | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
> index 91e2817..3f63d2a 100644
> --- a/xen/arch/arm/arm64/head.S
> +++ b/xen/arch/arm/arm64/head.S
> @@ -599,7 +599,9 @@ launch:
> mov x0, x20 /* Marshal args: - phys_offset */
> mov x1, x21 /* - FDT */
> mov x2, x24 /* - CPU ID */
> - cbz x22, start_xen /* and disappear into the land of C */
> + cbnz x22, 1f
> + b start_xen /* and disappear into the land of C */
> +1:
> b start_secondary /* (to the appropriate entry point) */
>
> /* Fail-stop */
> --
> 2.1.4
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-08-30 13:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 12:01 [PATCH 0/4] Fix gcov build Wei Liu
2016-08-30 12:01 ` [PATCH 1/4] arm: acpi/boot.c is only used during initialisation Wei Liu
2016-08-31 13:25 ` Julien Grall
2016-08-31 13:45 ` Wei Liu
2016-08-31 13:54 ` Julien Grall
2016-08-30 12:01 ` [PATCH 2/4] arm64: use "b" to branch to start_xen Wei Liu
2016-08-30 13:28 ` Konrad Rzeszutek Wilk [this message]
2016-08-31 13:40 ` Julien Grall
2016-08-30 12:01 ` [PATCH 3/4] xen: fix gcov compilation Wei Liu
2016-08-30 12:57 ` Ian Jackson
2016-08-30 12:59 ` Jan Beulich
2016-08-30 13:30 ` Wei Liu
2016-08-30 12:01 ` [PATCH 4/4] xen: add a gcov Kconfig option Wei Liu
2016-08-30 12:56 ` Jan Beulich
2016-08-30 13:06 ` Wei Liu
2016-08-30 16:49 ` Doug Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160830132846.GC12888@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).