From: Wei Liu <wei.liu2@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Julien Grall <julien.grall@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 2/5] gcov: collect more sections to constructor list
Date: Fri, 2 Sep 2016 13:12:02 +0100 [thread overview]
Message-ID: <20160902121202.GS21282@citrix.com> (raw)
In-Reply-To: <57C98593020000780010B45E@prv-mh.provo.novell.com>
On Fri, Sep 02, 2016 at 05:58:43AM -0600, Jan Beulich wrote:
> >>> On 02.09.16 at 13:47, <wei.liu2@citrix.com> wrote:
> > --- a/xen/arch/x86/xen.lds.S
> > +++ b/xen/arch/x86/xen.lds.S
> > @@ -205,6 +205,8 @@ SECTIONS
> > . = ALIGN(8);
> > __ctors_start = .;
> > *(.ctors)
> > + *(SORT(.init_array.*))
> > + *(.init_array)
> > __ctors_end = .;
> > } :text
>
> Is the ordering meaningful? If so, a comment is warranted. If not,
> elsewhere we have <section> precede <section>.* .
>
I don't think the order matters.
I will swap the position of the two entries.
Wei.
> Jan
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-09-02 12:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 11:47 [PATCH 0/5] gcov: more cleanup Wei Liu
2016-09-02 11:47 ` [PATCH 1/5] xen: add tainted state and show warning is gcov is enabled Wei Liu
2016-09-02 11:56 ` Jan Beulich
2016-09-02 12:01 ` Wei Liu
2016-09-02 12:06 ` Jan Beulich
2016-09-02 12:13 ` Andrew Cooper
2016-09-02 12:26 ` Jan Beulich
2016-09-02 12:30 ` Andrew Cooper
2016-09-02 13:34 ` Wei Liu
2016-09-02 13:21 ` Julien Grall
2016-09-02 13:34 ` Wei Liu
2016-09-02 11:47 ` [PATCH 2/5] gcov: collect more sections to constructor list Wei Liu
2016-09-02 11:58 ` Jan Beulich
2016-09-02 12:12 ` Wei Liu [this message]
2016-09-05 10:10 ` Julien Grall
2016-09-02 11:47 ` [PATCH 3/5] xen: replace TEST_COVERAGE with CONFIG_GCOV Wei Liu
2016-09-02 11:59 ` Jan Beulich
2016-09-19 14:30 ` Ian Jackson
2016-09-02 11:47 ` [PATCH 4/5] gcov: add option to determine gcov format Wei Liu
2016-09-02 12:01 ` Jan Beulich
2016-09-02 12:08 ` Wei Liu
2016-09-02 15:43 ` Wei Liu
2016-09-06 8:34 ` Wei Liu
2016-09-02 11:47 ` [PATCH 5/5] gcov: split out gcc version specific stuff Wei Liu
2016-09-02 12:04 ` [PATCH 0/5] gcov: more cleanup Andrew Cooper
2016-09-02 12:06 ` Wei Liu
2016-09-02 12:15 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160902121202.GS21282@citrix.com \
--to=wei.liu2@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).