* [PATCH] tools/firmware: Rename bios.bin to seabios.bin
@ 2016-08-19 14:26 Andrew Cooper
2016-08-22 10:24 ` Wei Liu
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Cooper @ 2016-08-19 14:26 UTC (permalink / raw)
To: Xen-devel; +Cc: Anthony PERARD, Andrew Cooper, Ian Jackson, Wei Liu
bios.bin as a name is far too generic. Rename it to seabios.bin.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
CC: Anthony PERARD <anthony.perard@citrix.com>
Please rerun autogen.sh
---
tools/configure | 2 +-
tools/configure.ac | 2 +-
tools/firmware/Makefile | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/configure b/tools/configure
index 81ccf34..dd82f67 100755
--- a/tools/configure
+++ b/tools/configure
@@ -4451,7 +4451,7 @@ fi
cat >>confdefs.h <<_ACEOF
-#define SEABIOS_PATH "${seabios_path:-$XENFIRMWAREDIR/bios.bin}"
+#define SEABIOS_PATH "${seabios_path:-$XENFIRMWAREDIR/seabios.bin}"
_ACEOF
diff --git a/tools/configure.ac b/tools/configure.ac
index c12ad79..06a6202 100644
--- a/tools/configure.ac
+++ b/tools/configure.ac
@@ -223,7 +223,7 @@ AC_ARG_WITH([system-seabios],
esac
],[])
AC_DEFINE_UNQUOTED([SEABIOS_PATH],
- ["${seabios_path:-$XENFIRMWAREDIR/bios.bin}"],
+ ["${seabios_path:-$XENFIRMWAREDIR/seabios.bin}"],
[SeaBIOS path])
AC_ARG_WITH([system-ovmf],
diff --git a/tools/firmware/Makefile b/tools/firmware/Makefile
index cf09ad2..b840c6a 100644
--- a/tools/firmware/Makefile
+++ b/tools/firmware/Makefile
@@ -42,7 +42,7 @@ install: all
[ -d $(INST_DIR) ] || $(INSTALL_DIR) $(INST_DIR)
[ ! -e $(TARGET) ] || $(INSTALL_DATA) $(TARGET) $(INST_DIR)
ifeq ($(CONFIG_SEABIOS),y)
- $(INSTALL_DATA) seabios-dir/out/bios.bin $(INST_DIR)/bios.bin
+ $(INSTALL_DATA) seabios-dir/out/bios.bin $(INST_DIR)/seabios.bin
endif
ifeq ($(CONFIG_OVMF),y)
$(INSTALL_DATA) ovmf-dir/ovmf.bin $(INST_DIR)/ovmf.bin
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] tools/firmware: Rename bios.bin to seabios.bin
2016-08-19 14:26 [PATCH] tools/firmware: Rename bios.bin to seabios.bin Andrew Cooper
@ 2016-08-22 10:24 ` Wei Liu
2016-09-05 8:09 ` Anthony PERARD
0 siblings, 1 reply; 6+ messages in thread
From: Wei Liu @ 2016-08-22 10:24 UTC (permalink / raw)
To: Andrew Cooper; +Cc: Anthony PERARD, Wei Liu, Ian Jackson, Xen-devel
On Fri, Aug 19, 2016 at 03:26:23PM +0100, Andrew Cooper wrote:
> bios.bin as a name is far too generic. Rename it to seabios.bin.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Hmm... I remember the first few versions of that series had it named
seabios.bin and I acked that.
Anyway, I think I will give Anthony a chance to clarify why he changed
the name.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tools/firmware: Rename bios.bin to seabios.bin
2016-08-22 10:24 ` Wei Liu
@ 2016-09-05 8:09 ` Anthony PERARD
2016-09-05 9:28 ` Andrew Cooper
0 siblings, 1 reply; 6+ messages in thread
From: Anthony PERARD @ 2016-09-05 8:09 UTC (permalink / raw)
To: Wei Liu; +Cc: Andrew Cooper, Ian Jackson, Xen-devel
On Mon, Aug 22, 2016 at 11:24:05AM +0100, Wei Liu wrote:
> On Fri, Aug 19, 2016 at 03:26:23PM +0100, Andrew Cooper wrote:
> > bios.bin as a name is far too generic. Rename it to seabios.bin.
> >
> > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> Hmm... I remember the first few versions of that series had it named
> seabios.bin and I acked that.
>
> Anyway, I think I will give Anthony a chance to clarify why he changed
> the name.
I've changed it because someone ask for it:
https://lists.xenproject.org/archives/html/xen-devel/2016-03/msg02371.html
It was to match how seabios is installed by default.
--
Anthony PERARD
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tools/firmware: Rename bios.bin to seabios.bin
2016-09-05 8:09 ` Anthony PERARD
@ 2016-09-05 9:28 ` Andrew Cooper
2016-09-05 9:31 ` Wei Liu
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Cooper @ 2016-09-05 9:28 UTC (permalink / raw)
To: Anthony PERARD, Wei Liu; +Cc: Doug Goldstein, Ian Jackson, Xen-devel
On 05/09/16 09:09, Anthony PERARD wrote:
> On Mon, Aug 22, 2016 at 11:24:05AM +0100, Wei Liu wrote:
>> On Fri, Aug 19, 2016 at 03:26:23PM +0100, Andrew Cooper wrote:
>>> bios.bin as a name is far too generic. Rename it to seabios.bin.
>>>
>>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> Hmm... I remember the first few versions of that series had it named
>> seabios.bin and I acked that.
>>
>> Anyway, I think I will give Anthony a chance to clarify why he changed
>> the name.
> I've changed it because someone ask for it:
> https://lists.xenproject.org/archives/html/xen-devel/2016-03/msg02371.html
It was admittedly lacking a question mark, but that was a question not a
statement.
The answer is "because there are a load of other bios binaries stored in
the same directory".
> It was to match how seabios is installed by default.
This is not relevant. The version of seabios built by Xen should fit
into the Xen expectations. If this means renaming it to make it clear
which bios it it, then so be it.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tools/firmware: Rename bios.bin to seabios.bin
2016-09-05 9:28 ` Andrew Cooper
@ 2016-09-05 9:31 ` Wei Liu
2016-09-05 10:54 ` Wei Liu
0 siblings, 1 reply; 6+ messages in thread
From: Wei Liu @ 2016-09-05 9:31 UTC (permalink / raw)
To: Andrew Cooper
Cc: Anthony PERARD, Ian Jackson, Wei Liu, Doug Goldstein, Xen-devel
On Mon, Sep 05, 2016 at 10:28:25AM +0100, Andrew Cooper wrote:
> On 05/09/16 09:09, Anthony PERARD wrote:
> > On Mon, Aug 22, 2016 at 11:24:05AM +0100, Wei Liu wrote:
> >> On Fri, Aug 19, 2016 at 03:26:23PM +0100, Andrew Cooper wrote:
> >>> bios.bin as a name is far too generic. Rename it to seabios.bin.
> >>>
> >>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> >> Hmm... I remember the first few versions of that series had it named
> >> seabios.bin and I acked that.
> >>
> >> Anyway, I think I will give Anthony a chance to clarify why he changed
> >> the name.
> > I've changed it because someone ask for it:
> > https://lists.xenproject.org/archives/html/xen-devel/2016-03/msg02371.html
>
> It was admittedly lacking a question mark, but that was a question not a
> statement.
>
> The answer is "because there are a load of other bios binaries stored in
> the same directory".
>
> > It was to match how seabios is installed by default.
>
> This is not relevant. The version of seabios built by Xen should fit
> into the Xen expectations. If this means renaming it to make it clear
> which bios it it, then so be it.
I think renaming it to seabios.bin is better.
Acked-by: Wei Liu <wei.liu2@citrix.com>
Wei.
>
> ~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tools/firmware: Rename bios.bin to seabios.bin
2016-09-05 9:31 ` Wei Liu
@ 2016-09-05 10:54 ` Wei Liu
0 siblings, 0 replies; 6+ messages in thread
From: Wei Liu @ 2016-09-05 10:54 UTC (permalink / raw)
To: Andrew Cooper
Cc: Anthony PERARD, Ian Jackson, Wei Liu, Doug Goldstein, Xen-devel
On Mon, Sep 05, 2016 at 10:31:21AM +0100, Wei Liu wrote:
> On Mon, Sep 05, 2016 at 10:28:25AM +0100, Andrew Cooper wrote:
> > On 05/09/16 09:09, Anthony PERARD wrote:
> > > On Mon, Aug 22, 2016 at 11:24:05AM +0100, Wei Liu wrote:
> > >> On Fri, Aug 19, 2016 at 03:26:23PM +0100, Andrew Cooper wrote:
> > >>> bios.bin as a name is far too generic. Rename it to seabios.bin.
> > >>>
> > >>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > >> Hmm... I remember the first few versions of that series had it named
> > >> seabios.bin and I acked that.
> > >>
> > >> Anyway, I think I will give Anthony a chance to clarify why he changed
> > >> the name.
> > > I've changed it because someone ask for it:
> > > https://lists.xenproject.org/archives/html/xen-devel/2016-03/msg02371.html
> >
> > It was admittedly lacking a question mark, but that was a question not a
> > statement.
> >
> > The answer is "because there are a load of other bios binaries stored in
> > the same directory".
> >
> > > It was to match how seabios is installed by default.
> >
> > This is not relevant. The version of seabios built by Xen should fit
> > into the Xen expectations. If this means renaming it to make it clear
> > which bios it it, then so be it.
>
> I think renaming it to seabios.bin is better.
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
>
Fixed up conflict and pushed.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-05 10:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-19 14:26 [PATCH] tools/firmware: Rename bios.bin to seabios.bin Andrew Cooper
2016-08-22 10:24 ` Wei Liu
2016-09-05 8:09 ` Anthony PERARD
2016-09-05 9:28 ` Andrew Cooper
2016-09-05 9:31 ` Wei Liu
2016-09-05 10:54 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).