From: Wei Liu <wei.liu2@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>, Doug Goldstein <cardoe@cardoe.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] tools/firmware: Rename bios.bin to seabios.bin
Date: Mon, 5 Sep 2016 10:31:21 +0100 [thread overview]
Message-ID: <20160905093121.GB18255@citrix.com> (raw)
In-Reply-To: <510881c6-27a3-d7ac-6af5-0b5a175ecb3e@citrix.com>
On Mon, Sep 05, 2016 at 10:28:25AM +0100, Andrew Cooper wrote:
> On 05/09/16 09:09, Anthony PERARD wrote:
> > On Mon, Aug 22, 2016 at 11:24:05AM +0100, Wei Liu wrote:
> >> On Fri, Aug 19, 2016 at 03:26:23PM +0100, Andrew Cooper wrote:
> >>> bios.bin as a name is far too generic. Rename it to seabios.bin.
> >>>
> >>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> >> Hmm... I remember the first few versions of that series had it named
> >> seabios.bin and I acked that.
> >>
> >> Anyway, I think I will give Anthony a chance to clarify why he changed
> >> the name.
> > I've changed it because someone ask for it:
> > https://lists.xenproject.org/archives/html/xen-devel/2016-03/msg02371.html
>
> It was admittedly lacking a question mark, but that was a question not a
> statement.
>
> The answer is "because there are a load of other bios binaries stored in
> the same directory".
>
> > It was to match how seabios is installed by default.
>
> This is not relevant. The version of seabios built by Xen should fit
> into the Xen expectations. If this means renaming it to make it clear
> which bios it it, then so be it.
I think renaming it to seabios.bin is better.
Acked-by: Wei Liu <wei.liu2@citrix.com>
Wei.
>
> ~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-09-05 9:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-19 14:26 [PATCH] tools/firmware: Rename bios.bin to seabios.bin Andrew Cooper
2016-08-22 10:24 ` Wei Liu
2016-09-05 8:09 ` Anthony PERARD
2016-09-05 9:28 ` Andrew Cooper
2016-09-05 9:31 ` Wei Liu [this message]
2016-09-05 10:54 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160905093121.GB18255@citrix.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=cardoe@cardoe.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).