Re: [PATCH] libxl: do not assume Dom0 backend while getting nic info

["Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1795 bytes --]

On Mon, Sep 05, 2016 at 10:39:16AM +0100, Wei Liu wrote:
> On Mon, Sep 05, 2016 at 11:26:04AM +0200, Marek Marczykowski-Górecki wrote:
> > Fill backend_domid field based on backend path.
> > 
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > Cc: Wei Liu <wei.liu2@citrix.com>
> > Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> 
> Acked-by: Wei Liu <wei.liu2@citrix.com>
> 
> I think this is a backport candidate?

Yes, certainly. If you want I can send a 4.7 version (function is in
libxl.c there).

In general, should I somehow somehow request a backport in the patch
itself? How?

> > ---
> >  tools/libxl/libxl_nic.c | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> > 
> > diff --git a/tools/libxl/libxl_nic.c b/tools/libxl/libxl_nic.c
> > index c34b7ba..d1caa90 100644
> > --- a/tools/libxl/libxl_nic.c
> > +++ b/tools/libxl/libxl_nic.c
> > @@ -309,6 +309,18 @@ static int libxl__device_nic_from_xenstore(libxl__gc *gc,
> >      else
> >          nic->devid = 0;
> >  
> > +    rc = libxl__xs_read_checked(gc, XBT_NULL,
> > +                                GCSPRINTF("%s/backend", libxl_path), &tmp);
> > +    if (rc) goto out;
> > +
> > +    if (!tmp) {
> > +        LOG(ERROR, "nic %s does not exist (no backend path)", libxl_path);
> > +        rc = ERROR_FAIL;
> > +        goto out;
> > +    }
> > +    rc = libxl__backendpath_parse_domid(gc, tmp, &nic->backend_domid);
> > +    if (rc) goto out;
> > +
> >      /* nic->mtu = */
> >  
> >      rc = libxl__xs_read_checked(gc, XBT_NULL,
> > -- 
> > 2.5.5
> > 

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel