From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Subject: Re: [PATCH] libxl: do not assume Dom0 backend while getting nic info Date: Mon, 5 Sep 2016 11:44:46 +0200 Message-ID: <20160905094446.GK21245@mail-itl> References: <1473067564-4092-1-git-send-email-marmarek@invisiblethingslab.com> <20160905093915.GC18255@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5675980257710129042==" Return-path: In-Reply-To: <20160905093915.GC18255@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Wei Liu Cc: Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org --===============5675980257710129042== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zGa1rFMfQatMxgJk" Content-Disposition: inline --zGa1rFMfQatMxgJk Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 05, 2016 at 10:39:16AM +0100, Wei Liu wrote: > On Mon, Sep 05, 2016 at 11:26:04AM +0200, Marek Marczykowski-G=C3=B3recki= wrote: > > Fill backend_domid field based on backend path. > >=20 > > Cc: Ian Jackson > > Cc: Wei Liu > > Signed-off-by: Marek Marczykowski-G=C3=B3recki >=20 > Acked-by: Wei Liu >=20 > I think this is a backport candidate? Yes, certainly. If you want I can send a 4.7 version (function is in libxl.c there). In general, should I somehow somehow request a backport in the patch itself? How? > > --- > > tools/libxl/libxl_nic.c | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > >=20 > > diff --git a/tools/libxl/libxl_nic.c b/tools/libxl/libxl_nic.c > > index c34b7ba..d1caa90 100644 > > --- a/tools/libxl/libxl_nic.c > > +++ b/tools/libxl/libxl_nic.c > > @@ -309,6 +309,18 @@ static int libxl__device_nic_from_xenstore(libxl__= gc *gc, > > else > > nic->devid =3D 0; > > =20 > > + rc =3D libxl__xs_read_checked(gc, XBT_NULL, > > + GCSPRINTF("%s/backend", libxl_path), &= tmp); > > + if (rc) goto out; > > + > > + if (!tmp) { > > + LOG(ERROR, "nic %s does not exist (no backend path)", libxl_pa= th); > > + rc =3D ERROR_FAIL; > > + goto out; > > + } > > + rc =3D libxl__backendpath_parse_domid(gc, tmp, &nic->backend_domid= ); > > + if (rc) goto out; > > + > > /* nic->mtu =3D */ > > =20 > > rc =3D libxl__xs_read_checked(gc, XBT_NULL, > > --=20 > > 2.5.5 > >=20 --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? --zGa1rFMfQatMxgJk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXzT6OAAoJENuP0xzK19cs2IgH/0lxm5eM3XVNKym6A1zqeCn8 oo4zIPok07x567vA2e271mJwGcsaI4WBuQiFxEdgUyRuJ6cM+Gqps5g5RIanne5M GlzrH7+d3f4Q+BIHmPlEFEiAteV6irkBJ4KnprTs1V8UAXU7XWjWQsuHGW6GKw7F kfx28D2z3AIN/Rw8TN8YWoW6lNekdvUnkmSUf74Yb11r/N1lZFLCBjtlsExcJZ0z panBbCk7Q3pmffJS1lQTdG8HaPskIWj2TA7iqR/6gObxhPUdSKUgej9uNP4d1V7u KpEw8Bk/5u5AglJdAi2Im5MsyTZe6SOznROixpFr8apLwrQktrg/lqVlsNYcTpA= =YClf -----END PGP SIGNATURE----- --zGa1rFMfQatMxgJk-- --===============5675980257710129042== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============5675980257710129042==--