* [PATCH] mini-os: add comments in Config.mk regarding new config options
@ 2016-09-05 11:43 Juergen Gross
2016-09-05 13:23 ` Samuel Thibault
0 siblings, 1 reply; 3+ messages in thread
From: Juergen Gross @ 2016-09-05 11:43 UTC (permalink / raw)
To: minios-devel, xen-devel; +Cc: Juergen Gross, samuel.thibault, wei.liu2
Add some comment in Config.mk what to do in case of adding new config
options.
Signed-off-by: Juergen Gross <jgross@suse.com>
---
Config.mk | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Config.mk b/Config.mk
index 0e405bf..0baedd1 100644
--- a/Config.mk
+++ b/Config.mk
@@ -152,6 +152,11 @@ CFLAGS += -flto
LDFLAGS-$(clang) += -plugin LLVMgold.so
endif
+# When adding a new CONFIG_ option please make sure the test configurations
+# under arch/*/testbuild/ are updated accordingly. Especially
+# arch/*/testbuild/*-yes and arch/*/testbuild/*-no should set ALL possible
+# CONFIG_ variables.
+
# Configuration defaults
ifeq ($(TARGET_ARCH_FAM),x86)
CONFIG_PARAVIRT ?= y
--
2.6.6
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mini-os: add comments in Config.mk regarding new config options
2016-09-05 11:43 [PATCH] mini-os: add comments in Config.mk regarding new config options Juergen Gross
@ 2016-09-05 13:23 ` Samuel Thibault
2016-09-05 13:47 ` Wei Liu
0 siblings, 1 reply; 3+ messages in thread
From: Samuel Thibault @ 2016-09-05 13:23 UTC (permalink / raw)
To: Juergen Gross; +Cc: minios-devel, xen-devel, wei.liu2
Juergen Gross, on Mon 05 Sep 2016 13:43:30 +0200, wrote:
> Add some comment in Config.mk what to do in case of adding new config
> options.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> Config.mk | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Config.mk b/Config.mk
> index 0e405bf..0baedd1 100644
> --- a/Config.mk
> +++ b/Config.mk
> @@ -152,6 +152,11 @@ CFLAGS += -flto
> LDFLAGS-$(clang) += -plugin LLVMgold.so
> endif
>
> +# When adding a new CONFIG_ option please make sure the test configurations
> +# under arch/*/testbuild/ are updated accordingly. Especially
> +# arch/*/testbuild/*-yes and arch/*/testbuild/*-no should set ALL possible
> +# CONFIG_ variables.
> +
> # Configuration defaults
> ifeq ($(TARGET_ARCH_FAM),x86)
> CONFIG_PARAVIRT ?= y
> --
> 2.6.6
>
--
Samuel
+#if defined(__alpha__) && defined(CONFIG_PCI)
+ /*
+ * The meaning of life, the universe, and everything. Plus
+ * this makes the year come out right.
+ */
+ year -= 42;
+#endif
(From the patch for 1.3.2: (kernel/time.c), submitted by Marcus Meissner)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mini-os: add comments in Config.mk regarding new config options
2016-09-05 13:23 ` Samuel Thibault
@ 2016-09-05 13:47 ` Wei Liu
0 siblings, 0 replies; 3+ messages in thread
From: Wei Liu @ 2016-09-05 13:47 UTC (permalink / raw)
To: Samuel Thibault, Juergen Gross, minios-devel, xen-devel, wei.liu2
On Mon, Sep 05, 2016 at 03:23:10PM +0200, Samuel Thibault wrote:
> Juergen Gross, on Mon 05 Sep 2016 13:43:30 +0200, wrote:
> > Add some comment in Config.mk what to do in case of adding new config
> > options.
> >
> > Signed-off-by: Juergen Gross <jgross@suse.com>
>
> Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
>
Pushed.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-05 13:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-05 11:43 [PATCH] mini-os: add comments in Config.mk regarding new config options Juergen Gross
2016-09-05 13:23 ` Samuel Thibault
2016-09-05 13:47 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).