From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH v6 3/6] livepatch: NOP if func->new_addr is zero. Date: Mon, 19 Sep 2016 12:11:59 -0400 Message-ID: <20160919161158.GC9860@localhost.localdomain> References: <1474039754-25816-1-git-send-email-konrad.wilk@oracle.com> <1474039754-25816-4-git-send-email-konrad.wilk@oracle.com> <57DFC514020000780010FDBF@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bm1B9-0008I0-BU for xen-devel@lists.xenproject.org; Mon, 19 Sep 2016 16:12:23 +0000 Content-Disposition: inline In-Reply-To: <57DFC514020000780010FDBF@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: andrew.cooper3@citrix.com, xen-devel@lists.xenproject.org, ross.lagerwall@citrix.com List-Id: xen-devel@lists.xenproject.org T24gTW9uLCBTZXAgMTksIDIwMTYgYXQgMDI6NTk6MzJBTSAtMDYwMCwgSmFuIEJldWxpY2ggd3Jv dGU6Cj4gPj4+IE9uIDE2LjA5LjE2IGF0IDE3OjI5LCA8a29ucmFkLndpbGtAb3JhY2xlLmNvbT4g d3JvdGU6Cj4gPiBAQCAtMzEsMTEgKzMwLDExIEBAIHZvaWQgYXJjaF9saXZlcGF0Y2hfcmV2aXZl KHZvaWQpCj4gPiAgCj4gPiAgaW50IGFyY2hfbGl2ZXBhdGNoX3ZlcmlmeV9mdW5jKGNvbnN0IHN0 cnVjdCBsaXZlcGF0Y2hfZnVuYyAqZnVuYykKPiA+ICB7Cj4gPiAtICAgIC8qIE5vIE5PUCBwYXRj aGluZyB5ZXQuICovCj4gPiAtICAgIGlmICggIWZ1bmMtPm5ld19zaXplICkKPiA+ICsgICAgLyog SWYgTk9QaW5nIG9ubHkgZG8gdXAgdG8gbWF4aW11bSBhbW91bnQgd2UgY2FuIHB1dCBpbiB0aGUg LT5vcGFxdWUuICovCj4gPiArICAgIGlmICggIWZ1bmMtPm5ld19hZGRyICYmIGZ1bmMtPm5ld19z aXplID4gc2l6ZW9mKGZ1bmMtPm9wYXF1ZSkgKQo+ID4gICAgICAgICAgcmV0dXJuIC1FT1BOT1RT VVBQOwo+ID4gIAo+ID4gLSAgICBpZiAoIGZ1bmMtPm9sZF9zaXplIDwgUEFUQ0hfSU5TTl9TSVpF ICkKPiA+ICsgICAgaWYgKCBmdW5jLT5vbGRfc2l6ZSA8IEFSQ0hfUEFUQ0hfSU5TTl9TSVpFICkK PiA+ICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+IAo+IElzIHRoYXQgaW5kZWVkIGEgcmVxdWly ZW1lbnQgd2hlbiBOT1Bpbmc/IFlvdSBjYW4gZWFzaWx5IE5PUCBvdXQKPiBqdXN0IGEgc2luZ2xl IGJ5dGUgb24geDg2LiBPciBzaG91bGRuJ3QgaW4gdGhhdCBjYXNlIG9sZF9zaXplID09IG5ld19z aXplCj4gYW55d2F5PyBJbiB3aGljaCBjYXNlIHRoZSBjb21tZW50IGZ1cnRoZXIgZG93biBzdGF0 aW5nIHRoYXQgbmV3X3NpemUKClRoZSBvcmlnaW5hbCBpbnRlbnQgYmVoaW5kIC5vbGRfc2l6ZSB3 YXMgdG8gZ3VhcmQgYWdhaW5zdCBwYXRjaGluZwpmdW5jdGlvbnMgdGhhdCB3ZXJlIGxlc3MgdGhh biBvdXIgcmVsYXRpdmUganVtcC4gCgooVGhlIHRvb2xzIGVuZCB1cCBjb21wdXRpbmcgdGhlIC5v bGRfc2l6ZSBhcyB0aGUgc2l6ZSBvZiB0aGUgd2hvbGUgZnVuY3Rpb24Kd2hpY2ggaXMgZmluZSku CgpCdXQgd2l0aCB0aGlzIE5PUGluZyBzdXBwb3J0LCB5b3UgYXJlIHJpZ2h0IC0gd2UgY291bGQg aGF2ZSBub3cgYW4KZnVuY3Rpb24gdGhhdCBpcyBzYXkgNCBieXRlcyBsb25nIGFuZCB3ZSBvbmx5 IG5lZWQgdG8gTk9QIHRocmVlIGJ5dGVzCm91dCBvZiBpdCAodGhlIGxhc3QgaW5zdHJ1Y3Rpb24g SSBhc3N1bWUgd291bGQgYmUgJ3JldCcpLgoKU28gcGVyaGFwcyB0aGlzIGNoZWNrIG5lZWRzIGp1 c3QgbmVlZHMgYW4gJ2Vsc2UgaWYnICwgbGlrZSBzbzoKCmludCBhcmNoX2xpdmVwYXRjaF92ZXJp ZnlfZnVuYyhjb25zdCBzdHJ1Y3QgbGl2ZXBhdGNoX2Z1bmMgKmZ1bmMpCnsKICAgIC8qIElmIE5P UGluZy4uICovCiAgICBpZiAoICFmdW5jLT5uZXdfYWRkciApCiAgICB7CiAgICAgICAgLyogT25s eSBkbyB1cCB0byBtYXhpbXVtIGFtb3VudCB3ZSBjYW4gcHV0IGluIHRoZSAtPm9wYXF1ZS4gKi8K ICAgICAgICBpZiAoIGZ1bmMtPm5ld19zaXplID4gc2l6ZW9mKGZ1bmMtPm9wYXF1ZSkgKQogICAg ICAgICAgICByZXR1cm4gLUVPUE5PVFNVUFA7CgogICAgICAgIC8qIE9uZSBpbnN0cnVjdGlvbiBm b3IgJ3JldCcgYW5kIHRoZSBvdGhlciB0byBOT1AuICovCiAgICAgICAgaWYgKCBmdW5jLT5vbGRf c2l6ZSA8IDIgKQogICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsKICAgIH0KICAgIGVsc2UgaWYg KCBmdW5jLT5vbGRfc2l6ZSA8IEFSQ0hfUEFUQ0hfSU5TTl9TSVpFICkKICAgICAgICByZXR1cm4g LUVJTlZBTDsKCiAgICByZXR1cm4gMDsKfQoKW0FuZCB1cGRhdGUgdGhlIGRlc2lnbl0KPiBjYW4g YmUgemVybyB3b3VsZCBhbHNvIGJlIHdyb25nLgo+IAo+ID4gQEAgLTQzLDIzICs0MiwzNiBAQCBp bnQgYXJjaF9saXZlcGF0Y2hfdmVyaWZ5X2Z1bmMoY29uc3Qgc3RydWN0IGxpdmVwYXRjaF9mdW5j ICpmdW5jKQo+ID4gIAo+ID4gIHZvaWQgYXJjaF9saXZlcGF0Y2hfYXBwbHlfam1wKHN0cnVjdCBs aXZlcGF0Y2hfZnVuYyAqZnVuYykKPiA+ICB7Cj4gPiAtICAgIGludDMyX3QgdmFsOwo+ID4gICAg ICB1aW50OF90ICpvbGRfcHRyOwo+ID4gLQo+ID4gLSAgICBCVUlMRF9CVUdfT04oUEFUQ0hfSU5T Tl9TSVpFID4gc2l6ZW9mKGZ1bmMtPm9wYXF1ZSkpOwo+ID4gLSAgICBCVUlMRF9CVUdfT04oUEFU Q0hfSU5TTl9TSVpFICE9ICgxICsgc2l6ZW9mKHZhbCkpKTsKPiA+ICsgICAgdWludDhfdCBpbnNu W3NpemVvZihmdW5jLT5vcGFxdWUpXTsKPiA+ICsgICAgdW5zaWduZWQgaW50IGxlbjsKPiA+ICAK PiA+ICAgICAgb2xkX3B0ciA9IGZ1bmMtPm9sZF9hZGRyOwo+ID4gLSAgICBtZW1jcHkoZnVuYy0+ b3BhcXVlLCBvbGRfcHRyLCBQQVRDSF9JTlNOX1NJWkUpOwo+ID4gKyAgICBsZW4gPSBsaXZlcGF0 Y2hfaW5zbl9sZW4oZnVuYyk7Cj4gPiArICAgIGlmICggIWxlbiApCj4gPiArICAgICAgICByZXR1 cm47Cj4gPiArCj4gPiArICAgIG1lbWNweShmdW5jLT5vcGFxdWUsIG9sZF9wdHIsIGxlbik7Cj4g PiArICAgIGlmICggZnVuYy0+bmV3X2FkZHIgKQo+ID4gKyAgICB7Cj4gPiArICAgICAgICBpbnQz Ml90IHZhbDsKPiA+ICsKPiA+ICsgICAgICAgIEJVSUxEX0JVR19PTihBUkNIX1BBVENIX0lOU05f U0laRSAhPSAoMSArIHNpemVvZih2YWwpKSk7Cj4gPiArCj4gPiArICAgICAgICBpbnNuWzBdID0g MHhlOTsKPiA+ICsgICAgICAgIHZhbCA9IGZ1bmMtPm5ld19hZGRyIC0gZnVuYy0+b2xkX2FkZHIg LSBBUkNIX1BBVENIX0lOU05fU0laRTsKPiA+ICsKPiA+ICsgICAgICAgIG1lbWNweSgmaW5zblsx XSwgJnZhbCwgc2l6ZW9mKHZhbCkpOwo+ID4gKyAgICB9Cj4gPiArICAgIGVsc2UKPiA+ICsgICAg ICAgIGFkZF9ub3BzKCZpbnNuLCBsZW4pOwo+ID4gIAo+ID4gLSAgICAqb2xkX3B0cisrID0gMHhl OTsgLyogUmVsYXRpdmUganVtcCAqLwo+IAo+IEFyZSB5b3UgYnR3IGludGVudGlvbmFsbHkgZ2V0 dGluZyByaWQgb2YgdGhpcyBjb21tZW50PyBBbmQgd2l0aCB0aGUKCk5vdCBhdCBhbGwuIEp1c3Qg bWlzc2VkIGl0Lgo+IE5PUCBhZGRpdGlvbiBoZXJlLCBwZXJoYXBzIHdvcnRoIGRyb3BwaW5nIHRo ZSBfam1wIGZyb20gdGhlCj4gZnVuY3Rpb24gbmFtZSAoYW5kIGl0cyByZXZlcnQgY291bnRlcnBh cnQpPwoKT29oLCBnb29kIGlkZWEuIEJ1dCBJIHRoaW5rIGl0IG1heWJlIGJldHRlciBhcyBhIHNl cGVyYXRlIHBhdGNoIChhcyBpdAphbHNvIHRvdWNoZXMgdGhlIEFSTSBjb2RlKS4KCj4gCj4gPiAr c3RhdGljIGlubGluZSBzaXplX3QgbGl2ZXBhdGNoX2luc25fbGVuKGNvbnN0IHN0cnVjdCBsaXZl cGF0Y2hfZnVuYyAqZnVuYykKPiAKPiBJIHRoaW5rIGl0IHdvdWxkIGJlIG5pY2UgdG8gdXNlIGNv bnNpc3RlbnQgdHlwZXM6IFRoZSBjdXJyZW50IHNvbGUgY2FsbGVyCj4gc3RvcmVzIHRoZSByZXN1 bHQgb2YgdGhlIGZ1bmN0aW9uIGluIGFuIHVuc2lnbmVkIGludCwgYW5kIEkgc2VlIG5vIHJlYXNv bgo+IHdoeSB0aGUgZnVuY3Rpb24gY291bGRuJ3QgYWxzbyByZXR1cm4gc3VjaC4KCi9tZSBub2Rz LgoKPiAKPiBKYW4KPiAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0 cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=