From: Wei Liu <wei.liu2@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Jan Beulich <JBeulich@suse.com>, Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Paulina Szubarczyk <paulinaszubarczyk@gmail.com>
Subject: Re: [PATCH] tools: lift BUILD_BUG_ON to a tools header file
Date: Mon, 19 Sep 2016 17:52:10 +0100 [thread overview]
Message-ID: <20160919165210.GT30319@citrix.com> (raw)
In-Reply-To: <fe824525-2bb0-583d-ff34-5f1c07d931a3@citrix.com>
On Mon, Sep 19, 2016 at 05:48:38PM +0100, Andrew Cooper wrote:
> On 19/09/16 17:46, Wei Liu wrote:
> >On Mon, Sep 19, 2016 at 04:07:30PM +0100, Wei Liu wrote:
> >>Only define BUILD_BUG_ON when there isn't one already, because mini-os
> >>currently leaks that.
> >>
> >>Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> >>---
> >>Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> >>Cc: Paulina Szubarczyk <paulinaszubarczyk@gmail.com>
> >>
> >>This is a patch taken out of my branch to clean up some build system
> >>issues. It is still a bit ugly because BUILD_BUG_ON is conditionally
> >>defined to work around mini-os leaking BUILD_BUG_ON.
> >>
> >>Either this patch or "[PATCH v2] libs/gnttab: introduce
> >>XENGNTTAB_BUILD_BUG_ON" should be taken to unblock Paulina's work.
> >>---
> >> tools/firmware/hvmloader/rombios.c | 1 +
> >> tools/firmware/hvmloader/smbios.c | 1 +
> >> tools/firmware/hvmloader/util.h | 1 -
> >Oops, I just realise that these changes need an ack from Jan / Andrew.
> >
> >Jan and Andrew: Since I can do a partial revert if you're not happy
> >with those changes.
> >
> >Sorry for not having CC'ed you two earlier.
>
> HVMLoader really should be standalone IMO.
>
> However, while you are fixing that, can you also fix the broken header guard
> for xen-tools/libs.h ?
>
Sure, first thing tomorrow.
Wei.
> ~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-09-19 16:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 15:07 [PATCH] tools: lift BUILD_BUG_ON to a tools header file Wei Liu
2016-09-19 15:38 ` Ian Jackson
2016-09-19 16:19 ` Wei Liu
2016-09-19 16:46 ` Wei Liu
2016-09-19 16:48 ` Andrew Cooper
2016-09-19 16:52 ` Wei Liu [this message]
2016-09-20 7:42 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919165210.GT30319@citrix.com \
--to=wei.liu2@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=paulinaszubarczyk@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).